linux-kernel - Re: [PATCH v3 0/9] mtd: sharpslpart partition parser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170609013521.GL102137@google.com>
Date:   Thu, 8 Jun 2017 18:35:21 -0700
From:   Brian Norris <computersforpeace@...il.com>
To:     Andrea Adami <andrea.adami@...il.com>
Cc:     linux-mtd@...ts.infradead.org,
        David Woodhouse <dwmw2@...radead.org>,
        Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Marek Vasut <marek.vasut@...il.com>,
        Richard Weinberger <richard@....at>,
        Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Lee Jones <lee.jones@...aro.org>,
        Daniel Mack <daniel@...que.org>,
        Haojian Zhuang <haojian.zhuang@...il.com>,
        Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        Linus Walleij <linus.walleij@...aro.org>,
        Russell King <linux@...linux.org.uk>,
        linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 0/9] mtd: sharpslpart partition parser

On Thu, Jun 01, 2017 at 12:40:49AM +0200, Andrea Adami wrote:
> This patchset introduces a simple partition parser for the Sharp SL
> Series PXA handhelds. More details in the commit text.
> 
> I have set in cc the ARM PXA maintainers because this is the MTD part of
> a planned wider patchset cleaning the Zaurus board files. The MFD maintainers
> are also in cc (tmio.h change).
> 
> Changelog:
> v1 initial import of 2.4 sources [1]
> v2 refactor applying many suggested fixes [2]
> v3 put the partition parser types in the platform data
> 
> [1] https://github.com/LinuxPDA/Sharp_FTL_2.4.20
> [2] https://github.com/LinuxPDA/linux/commits/sharpslpart_v2
> 
> Andrea Adami (9):
>   mtd: sharpslpart: add sharpslpart MTD partition parser
>   mtd: nand: sharpsl.h: support partition parser types
>   mfd: nand: tmio.h: support partition parser types
>   mtd: nand: sharpsl.c: take in account partition parser types
>   mtd: nand: tmio_nand.c: take in account partition parser types
>   arm: pxa: corgi.c: remove hardcoded partitioning, use sharpslpart
>     parser
>   arm: pxa: tosa.c: remove hardcoded partitioning, use sharpslpart
>     parser
>   arm: pxa: spitz.c: remove hardcoded partitioning, use sharpslpart
>     parser
>   arm: pxa: poodle.c: remove hardcoded partitioning, use sharpslpart
>     parser

Barring my comments on patch 1 and Wolfram's comments on a few of the
others, for the whole series:

Reviewed-by: Brian Norris <computersforpeace@...il.com>

Once things are fixed up, this should probably go through MTD.

Brian