linux-kernel - Re: [PATCH v10 1/6] i2c: designware: Cleaning and comment style fixes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 9 Jun 2017 10:57:12 +0200
From:   Peter Rosin <peda@...ntia.se>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Luis Oliveira <Luis.Oliveira@...opsys.com>, wsa@...-dreams.de,
        robh+dt@...nel.org, mark.rutland@....com,
        jarkko.nikula@...ux.intel.com, mika.westerberg@...ux.intel.com,
        linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Ramiro.Oliveira@...opsys.com, Joao.Pinto@...opsys.com,
        CARLOS.PALMINHA@...opsys.com
Subject: Re: [PATCH v10 1/6] i2c: designware: Cleaning and comment style
 fixes.

On 2017-06-09 10:38, Andy Shevchenko wrote:
> On Fri, 2017-06-09 at 07:12 +0200, Peter Rosin wrote:
>> On 2017-06-08 19:36, Luis Oliveira wrote:
>>> @@ -984,12 +984,12 @@ int i2c_dw_probe(struct dw_i2c_dev *dev)
>>>  	}
>>>  
>>>  	i2c_dw_disable_int(dev);
>>> -	r = devm_request_irq(dev->dev, dev->irq, i2c_dw_isr,
>>> irq_flags,
>>> +	ret = devm_request_irq(dev->dev, dev->irq, i2c_dw_isr,
>>> irq_flags,
>>>  			     dev_name(dev->dev), dev);
>>
> 
>> Two extra spaces needed to align with the opening bracket.
> 
> It's a bikeshedding, though it looks like v11 is needed anyway (see
> kbuild bot complains), thus it might be addressed as well.
> 

Bikeshedding or not, checkpatch.pl --strict notifies about the issue
with:

CHECK: Alignment should match open parenthesis

Cheers,
peda