linux-kernel - Re: [PATCH v3 12/17] gpio: madera: Support Cirrus Logic Madera class codecs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYxbGcEd0wSAC8EyARSvc7Q6LJb0SLks+GPDvjKbG4=8g@mail.gmail.com>
Date:   Fri, 9 Jun 2017 11:08:25 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Richard Fitzgerald <rf@...nsource.wolfsonmicro.com>
Cc:     Lee Jones <lee.jones@...aro.org>, Mark Brown <broonie@...nel.org>,
        Alexandre Courbot <gnurou@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "open list:WOLFSON MICROELECTRONICS DRIVERS" 
        <patches@...nsource.wolfsonmicro.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 12/17] gpio: madera: Support Cirrus Logic Madera class codecs

On Fri, Jun 2, 2017 at 5:03 PM, Richard Fitzgerald
<rf@...nsource.wolfsonmicro.com> wrote:

> This adds support for the GPIOs on Cirrus Logic Madera class codecs.
> Any pins not used for special functions (see the pinctrl driver) can be
> used as general single-bit input or output lines. The number of available
> GPIOs varies between codecs.
>
> Signed-off-by: Nariman Poushin <nariman@...nsource.wolfsonmicro.com>
> Signed-off-by: Richard Fitzgerald <rf@...nsource.wolfsonmicro.com>
> Signed-off-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
> ---
> Changes since V2:
> - Minor change now to use the parent MFD DT node for out DT bindings

This looks good to me
Acked-by: Linus Walleij <linus.walleij@...aro.org>

I can also merge it through the GPIO tree once it is clear that the
MFD portions are getting merged.

> +config GPIO_MADERA
> +       bool "Cirrus Logic Madera class codecs"
> +       depends on PINCTRL_MADERA

As this guards compilation until the MFD driver arrives.

Yours,
Linus Walleij