linux-kernel - Re: [PATCH v2] acpi: handle the acpi hotplug schedule error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VewHLZ_R17_onFa=QAvmoNzSjmiyiB+0qsKaoXT7UW4wg@mail.gmail.com>
Date:   Fri, 9 Jun 2017 12:40:29 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     "Lee, Chun-Yi" <joeyli.kernel@...il.com>
Cc:     "Rafael J . Wysocki" <rjw@...ysocki.net>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Lee, Chun-Yi" <jlee@...e.com>, Len Brown <lenb@...nel.org>
Subject: Re: [PATCH v2] acpi: handle the acpi hotplug schedule error

On Fri, Jun 9, 2017 at 7:33 AM, Lee, Chun-Yi <joeyli.kernel@...il.com> wrote:
> Kernel should decrements the reference count of acpi device
> when the scheduling of acpi hotplug work is failed, and
> evaluates _OST to notify BIOS the failure.
>
> v2:
> To simplify the code. (Andy Shevchenko)
>
> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>
> Cc: Len Brown <lenb@...nel.org>

FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

> Cc: Andy Shevchenko <andy.shevchenko@...il.com>
> Signed-off-by: "Lee, Chun-Yi" <jlee@...e.com>
> ---
>  drivers/acpi/bus.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> index 34fbe02..91adb71 100644
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -427,12 +427,17 @@ static void acpi_bus_notify(acpi_handle handle, u32 type, void *data)
>             (driver->flags & ACPI_DRIVER_ALL_NOTIFY_EVENTS))
>                 driver->ops.notify(adev, type);
>
> -       if (hotplug_event && ACPI_SUCCESS(acpi_hotplug_schedule(adev, type)))
> -               return;
> +       if (hotplug_event) {
> +               if (ACPI_SUCCESS(acpi_hotplug_schedule(adev, type)))
> +                       return;
> +               goto err_put_device;
> +       }
>
>         acpi_bus_put_acpi_device(adev);
>         return;
>
> + err_put_device:
> +       acpi_bus_put_acpi_device(adev);
>   err:
>         acpi_evaluate_ost(handle, type, ost_code, NULL);
>  }
> --
> 2.10.2
>



-- 
With Best Regards,
Andy Shevchenko