linux-kernel - Re: [PATCH] gpio: mvebu: fix regmap_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87zidho4qz.fsf@free-electrons.com>
Date:   Fri, 09 Jun 2017 12:05:40 +0200
From:   Gregory CLEMENT <gregory.clement@...e-electrons.com>
To:     Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jason Cooper <jason@...edaemon.net>,
        Andrew Lunn <andrew@...n.ch>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        linux-arm-kernel@...ts.infradead.org,
        Chris Packham <Chris.Packham@...iedtelesis.co.nz>,
        Ralph Sennhauser <ralph.sennhauser@...il.com>
Subject: Re: [PATCH] gpio: mvebu: fix regmap_update_bits usage

Hi Thomas,
 
 On ven., juin 09 2017, Thomas Petazzoni <thomas.petazzoni@...e-electrons.com> wrote:

> Hello,
>
> On Fri,  9 Jun 2017 12:03:18 +0200, Gregory CLEMENT wrote:
>
>>  	regmap_update_bits(mvchip->regs, GPIO_IO_CONF_OFF,
>> -			   BIT(pin), 1);
>> +			   BIT(pin), BIT(pin));
>>  
>>  	return 0;
>>  }
>> @@ -364,7 +364,7 @@ static int mvebu_gpio_direction_output(struct gpio_chip *chip, unsigned int pin,
>>  	mvebu_gpio_set(chip, pin, value);
>>  
>>  	regmap_update_bits(mvchip->regs, GPIO_IO_CONF_OFF,
>> -			   BIT(pin), 0);
>> +			   BIT(pin), BIT(pin));
>
> Are you sure here? We want to clear the bit, so I guess the 0 is
> appropriate, no?

argh!

yes it was a mistake

Gregory

>
> Thomas
> -- 
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com