linux-kernel - Re: [PATCH 10/11] s390: drivers: convert to use DRIVER_ATTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Jun 2017 12:20:43 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Heiko Carstens <heiko.carstens@...ibm.com>
Cc:     linux-kernel@...r.kernel.org,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        Julian Wiedmann <jwi@...ux.vnet.ibm.com>,
        Ursula Braun <ubraun@...ux.vnet.ibm.com>,
        Peter Oberparleiter <oberpar@...ux.vnet.ibm.com>,
        Gerald Schaefer <gerald.schaefer@...ibm.com>,
        linux-s390@...r.kernel.org
Subject: Re: [PATCH 10/11] s390: drivers: convert to use DRIVER_ATTR_RO/WO

On Fri, Jun 09, 2017 at 12:11:41PM +0200, Heiko Carstens wrote:
> On Fri, Jun 09, 2017 at 11:03:13AM +0200, Greg Kroah-Hartman wrote:
> > We are trying to get rid of DRIVER_ATTR(), and the s390 drivers'
> > attributes can be trivially changed to use DRIVER_ATTR_RO() and
> > DRIVER_ATTR_WO().
> > 
> > Cc: Martin Schwidefsky <schwidefsky@...ibm.com>
> > Cc: Heiko Carstens <heiko.carstens@...ibm.com>
> > Cc: Julian Wiedmann <jwi@...ux.vnet.ibm.com>
> > Cc: Ursula Braun <ubraun@...ux.vnet.ibm.com>
> > Cc: Peter Oberparleiter <oberpar@...ux.vnet.ibm.com>
> > Cc: Gerald Schaefer <gerald.schaefer@...ibm.com>
> > Cc: <linux-s390@...r.kernel.org>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > ---
> >  drivers/s390/char/sclp.c          | 12 ++++++------
> >  drivers/s390/char/vmlogrdr.c      |  7 ++-----
> >  drivers/s390/net/ctcm_main.c      |  6 +++---
> >  drivers/s390/net/lcs.c            |  6 +++---
> >  drivers/s390/net/netiucv.c        | 14 ++++++--------
> >  drivers/s390/net/qeth_core_main.c |  6 +++---
> >  6 files changed, 23 insertions(+), 28 deletions(-)
> 
> I assume this will go upstream via your tree.

Yup, I can take it.

> Acked-by: Heiko Carstens <heiko.carstens@...ibm.com>

Thanks for the review!

greg k-h