linux-kernel - Re: [PATCH v2] dell-rbtn: constify rfkill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VeY-FHG7EZ4KYjB=upz-Hi-tHBp5fWqWqhvm0d-SqSVMw@mail.gmail.com>
Date:   Fri, 9 Jun 2017 13:25:20 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Bhumika Goyal <bhumirks@...il.com>
Cc:     Julia Lawall <julia.lawall@...6.fr>,
        Pali Rohár <pali.rohar@...il.com>,
        "dvhart@...radead.org" <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] dell-rbtn: constify rfkill_ops structures

On Fri, Jun 9, 2017 at 8:57 AM, Bhumika Goyal <bhumirks@...il.com> wrote:
> Add const to rfkill_ops structures that are only passed as an argument
> to the functions rfkill_alloc or samsung_new_rfkill. These arguments are
> of type const, so such structures can be annotated with const.
>

All three pushed to testing, thanks

> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>
> ---
> Changes since v1:
> * Split the changes to one patch per vendor.
>
>  drivers/platform/x86/dell-rbtn.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/dell-rbtn.c b/drivers/platform/x86/dell-rbtn.c
> index dcd9f40..6b5bbaf 100644
> --- a/drivers/platform/x86/dell-rbtn.c
> +++ b/drivers/platform/x86/dell-rbtn.c
> @@ -110,7 +110,7 @@ static int rbtn_rfkill_set_block(void *data, bool blocked)
>         return -EINVAL;
>  }
>
> -static struct rfkill_ops rbtn_ops = {
> +static const struct rfkill_ops rbtn_ops = {
>         .query = rbtn_rfkill_query,
>         .set_block = rbtn_rfkill_set_block,
>  };
> --
> 2.7.4
>



-- 
With Best Regards,
Andy Shevchenko