linux-kernel - Re: [PATCH 3/3] arm: dts: mt2701: Add display subsystem related nodes for MT2701

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Jun 2017 12:59:25 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Philipp Zabel <p.zabel@...gutronix.de>
Cc:     Erin Lo <erin.lo@...iatek.com>, srv_heupstream@...iatek.com,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        YT Shen <yt.shen@...iatek.com>
Subject: Re: [PATCH 3/3] arm: dts: mt2701: Add display subsystem related nodes
 for MT2701



On 09/06/17 10:22, Philipp Zabel wrote:
> Hi Matthias,
> 
> On Fri, 2017-06-09 at 10:14 +0200, Matthias Brugger wrote:
>>
>> On 01/06/17 08:08, Erin Lo wrote:
>>> From: YT Shen <yt.shen@...iatek.com>
>>>
>>> This patch adds the device nodes for the DISP function blocks for MT2701
>>>
>>> Signed-off-by: YT Shen <yt.shen@...iatek.com>
>>> Signed-off-by: Erin Lo <erin.lo@...iatek.com>
>>> ---
>>>    arch/arm/boot/dts/mt2701.dtsi | 84 +++++++++++++++++++++++++++++++++++++++++++
>>>    1 file changed, 84 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi
>>> index 4f110d5..e20b65c 100644
>>> --- a/arch/arm/boot/dts/mt2701.dtsi
>>> +++ b/arch/arm/boot/dts/mt2701.dtsi
>>> @@ -17,6 +17,7 @@
>>>    #include <dt-bindings/interrupt-controller/irq.h>
>>>    #include <dt-bindings/interrupt-controller/arm-gic.h>
>>>    #include <dt-bindings/reset/mt2701-resets.h>
>>> +#include <dt-bindings/memory/mt2701-larb-port.h>
>>>    #include "skeleton64.dtsi"
>>>    #include "mt2701-pinfunc.h"
>>>    
>>> @@ -24,6 +25,11 @@
>>>    	compatible = "mediatek,mt2701";
>>>    	interrupt-parent = <&sysirq>;
>>>    
>>> +	aliases {
>>> +		rdma0 = &rdma0;
>>> +		rdma1 = &rdma1;
>>> +	};
>>> +
>>
>> I know we have this alias in mt8173.dtsi, but I don't understand what
>> they are for. Do you know?
> 
> The mtk_disp_rdma platform driver uses mtk_ddp_comp_get_id() to identify
> the specific RDMA instance, which calls of_alias_get_id(). The core code
> needs to know which RDMA is which to correctly set up the display data
> paths.
> 

Ok, thanks for the clarification!

Matthias