linux-kernel - Re: [PATCH] mtd: nand: fsl_ifc: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Jun 2017 13:35:38 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Boris Brezillon <boris.brezillon@...e-electrons.com>
Cc:     Richard Weinberger <richard@....at>,
        David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Marek Vasut <marek.vasut@...il.com>,
        Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>,
        Pavel Machek <pavel@....cz>,
        linux-mtd <linux-mtd@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mtd: nand: fsl_ifc: remove unused variable

On Fri, Jun 9, 2017 at 12:56 PM, Boris Brezillon
<boris.brezillon@...e-electrons.com> wrote:
> On Fri,  9 Jun 2017 12:47:43 +0200
> Arnd Bergmann <arnd@...db.de> wrote:
>
>> This one was accidentally introduced without any references,
>> and it causes a harmless warning:
>>
>> drivers/mtd/nand/fsl_ifc_nand.c: In function 'fsl_ifc_read_page':
>> drivers/mtd/nand/fsl_ifc_nand.c:696:7: error: unused variable 'res' [-Werror=unused-variable]
>>
>> Fixes: 79f40cc12fd3 ("mtd: nand: fsl_ifc: fix handing of bit flips in erased pages")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> If you don't mind, I'll squash the change in the initial commit.

Sure, that's always the best way to do it when the commits are not yet stable.

       Arnd