linux-kernel - Re: [PATCH] arm64: ftrace: fix building without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Jun 2017 12:38:50 +0100
From:   Will Deacon <will.deacon@....com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Catalin Marinas <catalin.marinas@....com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>, Jessica Yu <jeyu@...nel.org>,
        Rusty Russell <rusty@...tcorp.com.au>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: ftrace: fix building without CONFIG_MODULES

Hi Arnd,

On Fri, Jun 09, 2017 at 12:27:06PM +0200, Arnd Bergmann wrote:
> When CONFIG_MODULES is disabled, we cannot dereference a module pointer:
> 
> arch/arm64/kernel/ftrace.c: In function 'ftrace_make_call':
> arch/arm64/kernel/ftrace.c:107:36: error: dereferencing pointer to incomplete type 'struct module'
>    trampoline = (unsigned long *)mod->arch.ftrace_trampoline;
> 
> Also, the within_module() function is not defined:
> 
> arch/arm64/kernel/ftrace.c: In function 'ftrace_make_nop':
> arch/arm64/kernel/ftrace.c:171:8: error: implicit declaration of function 'within_module'; did you mean 'init_module'? [-Werror=implicit-function-declaration]
> 
> This addresses both by adding the appropriate stubs.
> 
> Fixes: e71a4e1bebaf ("arm64: ftrace: add support for far branches to dynamic ftrace")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  arch/arm64/include/asm/module.h | 6 ++++++
>  arch/arm64/kernel/ftrace.c      | 2 +-
>  include/linux/module.h          | 5 +++++
>  3 files changed, 12 insertions(+), 1 deletion(-)

I can't seem to reproduce this simply by disabling MODULES in defconfig.
Could you share your .config, please?

Will