linux-kernel - Re: [PATCH] arm: aspeed: Add clock-names property to timer node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Jun 2017 15:44:08 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Joel Stanley <joel@....id.au>, Andrew Jeffery <andrew@...id.au>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>
Subject: Re: [PATCH] arm: aspeed: Add clock-names property to timer node

On Tue, Jun 6, 2017 at 11:41 AM, Arnd Bergmann <arnd@...db.de> wrote:
> On Mon, Jun 5, 2017 at 10:59 AM, Joel Stanley <joel@....id.au> wrote:
>> On Mon, Jun 5, 2017 at 5:18 PM, Andrew Jeffery <andrew@...id.au> wrote:
>>> The merging of a number of clocksource drivers into fttmr010 means we
>>> require clock-names to be specified in the Aspeed timer node, else the
>>> clocksource fails to probe and boot hangs.
>>
>> Arnd,
>>
>> Linus' reworked timer driver will go into 4.13.
>>
>> Can we get this patch merged into 4.12 as a fix so we don't end up
>> with a broken boot at any stage?
>
> Hmm, can't we make the driver backward-compatible and have it fall
> back on the first clock if no clk named "PCLK" is found? Otherwise
> you still have an incompatible change in the DT binding and it will
> break if someone uses an older dtb with a newer kernel.

I was under the impression that the Aspeed support is still in its
infancy and everyone working on it using DT will recompile and
bundle the DTB as part of their kernel build at this point in time.

Are there people shipping products with DTBs on this, really?

Yours,
Linus Walleij