linux-kernel - Re: [PATCH] loop: fix error handling regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fdc139d7-7f7c-2268-ac89-29292b779138@fb.com>
Date:   Fri, 9 Jun 2017 08:19:19 -0600
From:   Jens Axboe <axboe@...com>
To:     Arnd Bergmann <arnd@...db.de>
CC:     Ming Lei <tom.leiming@...il.com>, Hannes Reinecke <hare@...e.de>,
        Omar Sandoval <osandov@...com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] loop: fix error handling regression

On 06/09/2017 04:19 AM, Arnd Bergmann wrote:
> gcc points out an unusual indentation:
> 
> drivers/block/loop.c: In function 'loop_set_status':
> drivers/block/loop.c:1149:3: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
>    if (figure_loop_size(lo, info->lo_offset, info->lo_sizelimit,
>    ^~
> drivers/block/loop.c:1152:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
>     goto exit;
> 
> This was introduced by a new feature that accidentally moved the opening
> braces from one condition to another. Adding a second pair of braces
> makes it work correctly again and also more readable.

Thanks for fixing this Arnd, I did notice (and complained to Hannes) this
yesterday. Added.

-- 
Jens Axboe