linux-kernel - Re: [PATCH][-next] loop: fix incorrect nesting levels on braces in nested if statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7929f1eb-d796-6eba-52de-3c19ddcd2723@fb.com>
Date:   Fri, 9 Jun 2017 09:57:49 -0600
From:   Jens Axboe <axboe@...com>
To:     Colin King <colin.king@...onical.com>,
        Ming Lei <tom.leiming@...il.com>,
        Hannes Reinecke <hare@...e.de>, Omar Sandoval <osandov@...com>,
        Andrew Morton <akpm@...ux-foundation.org>
CC:     <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][-next] loop: fix incorrect nesting levels on braces in
 nested if statements

On 06/09/2017 09:54 AM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Adding another set of braces clarifies the block and ensures that
> both the setting of err and the error exit are executed on the
> deepest nested if statement.
> 
> Detected by CoverityScan, CID#1440959 ("Nesting level does not
> match indentation")

Already fixed:

http://git.kernel.dk/cgit/linux-block/commit/?h=for-4.13/block&id=b040ad9cf6a169cc000a5324fcada695dfa1f4b3

-- 
Jens Axboe