linux-kernel - Re: [PATCH 1/2] arch: Define CPU_BIG_ENDIAN for all fixed big endian archs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170609.124025.1597341888979066145.davem@davemloft.net>
Date:   Fri, 09 Jun 2017 12:40:25 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     babu.moger@...cle.com
Cc:     ysato@...rs.sourceforge.jp, geert@...ux-m68k.org,
        jonas@...thpole.se, stefan.kristiansson@...nalahti.fi,
        shorne@...il.com, jejb@...isc-linux.org, deller@....de,
        viro@...iv.linux.org.uk, mpe@...erman.id.au, peterz@...radead.org,
        mingo@...hat.com, jcmvbkbc@...il.com, linux-kernel@...r.kernel.org,
        uclinux-h8-devel@...ts.sourceforge.jp, linux-m68k@...r.kernel.org,
        openrisc@...ts.librecores.org, linux-parisc@...r.kernel.org,
        sparclinux@...r.kernel.org
Subject: Re: [PATCH 1/2] arch: Define CPU_BIG_ENDIAN for all fixed big
 endian archs

From: Babu Moger <babu.moger@...cle.com>
Date: Thu,  8 Jun 2017 15:17:22 -0700

> While working on enabling queued rwlock on SPARC, found
> this following code in include/asm-generic/qrwlock.h
> which uses CONFIG_CPU_BIG_ENDIAN to clear a byte.
> 
> static inline u8 *__qrwlock_write_byte(struct qrwlock *lock)
>  {
> 	return (u8 *)lock + 3 * IS_BUILTIN(CONFIG_CPU_BIG_ENDIAN);
>  }
> 
> Problem is many of the fixed big endian architectures dont define
> CPU_BIG_ENDIAN and clears the wrong byte.
> 
> Define CPU_BIG_ENDIAN for all the fixed big endian architecture.
> 
> Here is the orinal discussion
> http://www.spinics.net/lists/devicetree/msg178101.html
> 
> Signed-off-by: Babu Moger <babu.moger@...cle.com>
> Suggested-by: Arnd Bergmann <arnd@...db.de>

Acked-by: David S. Miller <davem@...emloft.net>