linux-kernel - Re: [PATCH] nvme: use uuid_t in nvme

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VcWqRu3SqWjMG5WbKKmWmDeWNrHyfuoCX3zq_fc3dYgSw@mail.gmail.com>
Date:   Sat, 10 Jun 2017 18:40:19 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Johannes Thumshirn <jthumshirn@...e.de>
Cc:     Christoph Hellwig <hch@....de>,
        Linux NVMe Mailinglist <linux-nvme@...ts.infradead.org>,
        Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nvme: use uuid_t in nvme_ns

On Sat, Jun 10, 2017 at 4:03 PM, Johannes Thumshirn <jthumshirn@...e.de> wrote:

> struct nvme_ns still uses u u8 uuid[16], change it to using uuid_t.

...and we can convert to use UUID API.

> -                       memcpy(ns->uuid, data + pos + sizeof(*cur), len);
> +                       memcpy(&ns->uuid, data + pos + sizeof(*cur), len);

uuid_copy()

> -       if (!memchr_inv(ns->uuid, 0, sizeof(ns->uuid))) {
> +       if (!memchr_inv(&ns->uuid, 0, sizeof(ns->uuid))) {

uuid_is_null()

> -               if (!memchr_inv(ns->uuid, 0, sizeof(ns->uuid)) ||
> +               if (!memchr_inv(&ns->uuid, 0, sizeof(ns->uuid)) ||

Ditto.

-- 
With Best Regards,
Andy Shevchenko