linux-kernel - Re: [PATCH] drm: Use vsnprintf extension %ph

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VcwKGmBHGk2NLEzsWofOOH5_rqnvfksx1Vq-+B1--gO+A@mail.gmail.com>
Date:   Sat, 10 Jun 2017 19:12:28 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Daniel Vetter <daniel.vetter@...el.com>,
        Jani Nikula <jani.nikula@...ux.intel.com>,
        Sean Paul <seanpaul@...omium.org>,
        David Airlie <airlied@...ux.ie>,
        dri-devel@...ts.freedesktop.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm: Use vsnprintf extension %ph

On Wed, May 31, 2017 at 2:35 AM, Joe Perches <joe@...ches.com> wrote:
> Using the extension saves a bit of code.

> +               seq_printf(m, "faux/mst: %*ph\n", 2, buf);

> +               seq_printf(m, "mst ctrl: %*ph\n", 1, buf);

> +               seq_printf(m, "branch oui: %*phN devid: ", 3, buf);

All above may use shorter form, i.e.
"..., "%Xph", buf);", where X is a constant written explicitly inplace.

> +               seq_printf(m, " revision: hw: %x.%x sw: %x.%x\n",
> +                          buf[0x9] >> 4, buf[0x9] & 0xf, buf[0xa], buf[0xb]);

Matter of taste, though buf[9], buf[10], buf[11] looks better to me :-)

-- 
With Best Regards,
Andy Shevchenko