linux-kernel - Re: [PATCH v2 3/3] remoteproc/keystone: Ensure the DSPs are in reset in probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ce5952b-55b0-8f77-2e14-51110d6bf979@oracle.com>
Date:   Sat, 10 Jun 2017 12:32:43 -0700
From:   Santosh Shilimkar <santosh.shilimkar@...cle.com>
To:     Suman Anna <s-anna@...com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Ohad Ben-Cohen <ohad@...ery.com>
Cc:     Santosh Shilimkar <ssantosh@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-remoteproc@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, "Andrew F. Davis" <afd@...com>,
        Sam Nelson <sam.nelson@...com>
Subject: Re: [PATCH v2 3/3] remoteproc/keystone: Ensure the DSPs are in reset
 in probe

On 6/7/2017 5:24 PM, Suman Anna wrote:
> From: "Andrew F. Davis" <afd@...com>
> 
> The DSPs are expected to be in reset when the driver probes a device.
> If the DSPs are out of reset in probe, the system may crash when the
> firmware is being loaded. So, add a check to make sure the DSP resets
> are asserted, and if not, throw a eye-catchy warning and assert the
> resets specifically.
> 
> Signed-off-by: Andrew F. Davis <afd@...com>
> [s-anna@...com: replace warning with a WARN]
> Signed-off-by: Suman Anna <s-anna@...com>
> ---
Acked-by: Santosh Shilimkar <ssantosh@...nel.org>