linux-kernel - Re: [git pull] first batch of ufs fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.21.1706111242000.2371@joy.test>
Date:   Sun, 11 Jun 2017 12:47:40 -0700 (PDT)
From:   Richard Narron <comet.berkeley@...il.com>
To:     Al Viro <viro@...IV.linux.org.uk>
cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [git pull] first batch of ufs fixes

The ufs fixes are looking good, much better than what we started with.

After applying the 8 ufs patches:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
/commit/?id=5faab9e0f03c4eef97886b45436015e107f79f5f

Copying files to FreeBSD 11.0 (ufs2) and NetBSD 7.1 (ufs2) looks
pretty good.

I can copy a large >2GB file, create a directory and then run and 
fsck without errors with a FreeBSD disk and a NetBSD disk.

But...

1) Creating an OpenBSD 6.1 (44bsd) disk and then on Linux copying a 
large > 2GB file and creating a directory, there are errors on OpenBSD
with the fsck:

OpenBSD (44bsd):
   #fsck sd0e
   ** /dev/rsd0e
   ** File system is already clean
   ** Last Mounted on /diske
   ** Phase 1 - Check Blocks and Sizes
   ** Phase 2 - Check Pathnames
   ** Phase 3 - Check Connectivity
   ** Phase 4 - Check Reference Counts
   ** Phase 5 - Check Cyl groups
   FREE BLK COUNT(S) WRONG IN SUPERBLK
   SALVAGE? [Fyn?]
   3 files, 1272410 used, 6983197 free (13 frags, 872898 blocks, 0.0% fragmentation)

   ***** FILE SYSTEM WAS MODIFIED *****

And also after removing the files on Linux, there were errors in
the fsck on OpenBSD:

   #fsck sd0e
   ** /dev/rsd0e
   ** File system is already clean
   ** Last Mounted on /diske
   ** Phase 1 - Check Blocks and Sizes
   ** Phase 2 - Check Pathnames
   ** Phase 3 - Check Connectivity
   ** Phase 4 - Check Reference Counts
   ** Phase 5 - Check Cyl groups
   FREE BLK COUNT(S) WRONG IN SUPERBLK
   SALVAGE? [Fyn?]
   1 files, 1 used, 8255606 free (14 frags, 1031949 blocks, 0.0% fragmentation)

   ***** FILE SYSTEM WAS MODIFIED *****

2) The available block counts on a newly created FreeBSD 11.0
     ufs2 filesystem (13079640) differ from Linux 4.12-rc4 (13079656):

Freebsd (ufs2):
   #df /diske
   Filesystem   1K-blocks Used    Avail Capacity  Mounted on
   /dev/ada0s3e  14217008    8 13079640     0%    /diske
Linux:
   #df /fbsd23
   Filesystem     1K-blocks  Used Available Use% Mounted on
   /dev/sda23      14217008     8  13079656   1% /fbsd23

3) The available block counts on a newly created NetBSD 7.1
     ufs2 filesystem (9518316) differ from Linux 4.12-rc4 (9518314):

NetBSD (ufs2):
   #df /nbsdf
   Filesystem     1K-blocks  Used Available Use% Mounted on
   /dev/sda22      10019278     2   9518316   1% /nbsdf
Linux:
   #df /diskf
   Filesystem    1K-blocks       Used      Avail %Cap Mounted on
   /dev/wd0f      10019278          2    9518314   0% /diskf