linux-kernel - Re: [PATCH v1] misc: apds990x: Use sysfs_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdW8-Ee6Ev37SC8J-pKX_-kcK=EcL5rRTnhE_Ay_z03rAA@mail.gmail.com>
Date:   Sun, 11 Jun 2017 10:57:25 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v1] misc: apds990x: Use sysfs_match_string() helper

On Sun, Jun 11, 2017 at 9:47 AM, Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
> On Fri, Jun 09, 2017 at 03:07:58PM +0300, Andy Shevchenko wrote:
>> Use sysfs_match_string() helper instead of open coded variant.
>>
>> Cc: Arnd Bergmann <arnd@...db.de>
>> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>> ---
>>  drivers/misc/apds990x.c | 12 ++++++------
>>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> kbuild is failing :(

reporting_modes[] is not an array of string pointers, but an array of
9-byte arrays. Converting it to an array of pointers should fix this.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds