linux-kernel - Re: [PATCH v2 2/4] dt: bindings: Add bindings for bcm2835-aux-intc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5093ed34-a930-dea5-6642-03e1e4910362@gmail.com>
Date:   Mon, 12 Jun 2017 11:21:19 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Phil Elwell <phil@...pberrypi.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <marc.zyngier@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Stefan Wahren <stefan.wahren@...e.com>,
        Eric Anholt <eric@...olt.net>,
        Russell King <linux@...linux.org.uk>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...eaurora.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-rpi-kernel@...ts.infradead.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH v2 2/4] dt: bindings: Add bindings for bcm2835-aux-intc

On 06/12/2017 07:25 AM, Phil Elwell wrote:
> Add bindings documentation for brcm,bcm2835-aux-intc and human-readable
> declarations for the BCM2835 AUX IRQs.
> 
> Signed-off-by: Phil Elwell <phil@...pberrypi.org>
> ---
>  .../interrupt-controller/brcm,bcm2835-aux-intc.txt | 28 ++++++++++++++++++++++
>  .../interrupt-controller/bcm2835-aux-intc.h        | 20 ++++++++++++++++
>  2 files changed, 48 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2835-aux-intc.txt
>  create mode 100644 include/dt-bindings/interrupt-controller/bcm2835-aux-intc.h
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2835-aux-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2835-aux-intc.txt
> new file mode 100644
> index 0000000..f3f895c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2835-aux-intc.txt
> @@ -0,0 +1,28 @@
> +BCM2835 Auxiliary ("AUXIRQ") Interrupt Controller
> +
> +The BCM2835 family of SoCs multiplexes the interrupts for peripherals in
> +the AUX block into a single IRQ. The AUXIRQ register shows the IRQ status
> +of each of the peripherals. Note that there are no masking or clearing
> +facilities - interrupts must be enabled and acknowledged in the
> +individual peripherals.
> +
> +Required properties:
> +- compatible :	     Should be "brcm,bcm2835-aux-intc".
> +- reg :		     Specifies base physical address and size of the registers.
> +- interrupts :	     The interrupt number - see
> +		     bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt
> +- interrupt-controller : Identifies the node as an interrupt controller
> +- #interrupt-cells : Specifies the number of cells needed to encode an
> +		     interrupt source. The value shall be 1.
> +
> +  The cell contains the interrupt specifier, as found in
> +  include/dt-bindings/interrupt-controller/bcm2835-aux-intc.h. Valid values
> +  are 0..2.

This last sentence is sort of doomed for failure in case there are
additional interrupts being added in the future, referring to
bcm2835-aux-intc.h seems to be good enough IMHO.

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian