linux-kernel - Re: udf: allow implicit blocksize specification during mount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <201706122240.14996@pali>
Date:   Mon, 12 Jun 2017 22:40:14 +0200
From:   Pali Rohár <pali.rohar@...il.com>
To:     Fabian Frederick <fabf@...net.be>, Jan Kara <jack@...e.cz>,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: udf: allow implicit blocksize specification during mount

Hi! I found that following UDF patch was included into linus tree:
https://patchwork.kernel.org/patch/9524557/

It is really a good improvement to recognize UDF file system which have 
block size different from disk sector size and also different from 2048.

But should not detection on 4K native disks (4096/4096) try to also use 
block size of 512 bytes? Because current loop is from logical sector 
size to 4096.

Most of current hard drivers are 512/4096 (logical/physical), but there 
are available USB based SATA controllers which via USB mass storage mode 
reports logical block size value from physical block size of SATA disk. 
So via such SATA controller computer see 4096/4096 disk and is unable to 
detect UDF file system if was formatted with 512 block size.

Anyway, macro UDF_DEFAULT_BLOCKSIZE is not used in udf source code 
anymore, so it can be deleted. I think its name was incorrect as default 
block size for UDF should be logical block size of disk, not hardcoded 
value 2048 which is logical block size for optical media.

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)