linux-kernel - Re: [PATCH] pci: endpoint: fix endpoint test build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170612204825.GB28578@bhelgaas-glaptop.roam.corp.google.com>
Date:   Mon, 12 Jun 2017 15:48:25 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-pci <linux-pci@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Kishon Vijay Abraham I <kishon@...com>
Subject: Re: [PATCH] pci: endpoint: fix endpoint test build error

On Sun, Jun 11, 2017 at 07:10:38PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@...radead.org>
> 
> PCI endpoint test driver uses crc32_le() so it should select
> CRC32. Fixes this build error (when CRC32=m):
> 
>   drivers/built-in.o: In function `pci_epf_test_cmd_handler':
>   pci-epf-test.c:(.text+0x2d98d): undefined reference to `crc32_le'
> 
> Fixes 349e7a85b25f (PCI: endpoint: functions: Add an EP function to test PCI).
> 
> Reported-by: kbuild test robot <fengguang.wu@...el.com>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>

Applied with Kishon's ack to for-linus for v4.12 (since 349e7a85b25f first
appeared in v4.12-rc1), thanks!

> Cc: Kishon Vijay Abraham I <kishon@...com>
> Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> ---
>  drivers/pci/endpoint/functions/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- lnx-412-rc4.orig/drivers/pci/endpoint/functions/Kconfig
> +++ lnx-412-rc4/drivers/pci/endpoint/functions/Kconfig
> @@ -5,6 +5,7 @@
>  config PCI_EPF_TEST
>  	tristate "PCI Endpoint Test driver"
>  	depends on PCI_ENDPOINT
> +	select CRC32
>  	help
>  	   Enable this configuration option to enable the test driver
>  	   for PCI Endpoint.
> 
>