linux-kernel - Re: [10/10] Staging: rtl8712: ieee80211: fixed coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170612205711.GA28052@roeck-us.net>
Date:   Mon, 12 Jun 2017 13:57:11 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Jaya Durga <jayad@...c.in>
Cc:     gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
        florian.c.schilhabel@...glemail.com,
        driverdev-devel@...uxdriverproject.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [10/10] Staging: rtl8712: ieee80211: fixed coding style issue

On Mon, Jun 12, 2017 at 12:14:06AM +0530, Jaya Durga wrote:
> Fixed WARNING: line over 80 characters
> 
> Signed-off-by: Jaya Durga <jayad@...c.in>
> ---
>  drivers/staging/rtl8712/ieee80211.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --
> 1.9.1
> 
> diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c
> index 6e673c1..97ef063 100644
> --- a/drivers/staging/rtl8712/ieee80211.c
> +++ b/drivers/staging/rtl8712/ieee80211.c
> @@ -174,8 +174,8 @@ int r8712_generate_ie(struct registry_priv *pregistrypriv)
> 	sz += 8;
> 	ie += sz;
> 	/*beacon interval : 2bytes*/
> -	*(__le16 *)ie = cpu_to_le16(
> -				(u16)pdev_network->configuration.beacon_period);
> +	struct NDIS_802_11_CONFIGURATION *cfg = &pdev_network->configuration;
> +	*(__le16 *)ie = cpu_to_le16(cfg->beacon_period);

Do you really think that the resulting 

drivers/staging/rtl8712/ieee80211.c:177:2: warning:
	ISO C90 forbids mixed declarations and code

is better ?

Guenter

> 	sz += 2;
> 	ie += 2;
> 	/*capability info*/