linux-kernel - Re: [PATCH] ARM: dts: omap3-overo: Remove "vqmmc-supply" property from MMC dt node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 12 Jun 2017 09:58:49 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Kishon Vijay Abraham I <kishon@...com>
Cc:     Tony Lindgren <tony@...mide.com>,
        Florian Vaussard <florian.vaussard@...l.ch>,
        linux-omap <linux-omap@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Sekhar Nori <nsekhar@...com>
Subject: Re: [PATCH] ARM: dts: omap3-overo: Remove "vqmmc-supply" property
 from MMC dt node

On 9 June 2017 at 10:41, Kishon Vijay Abraham I <kishon@...com> wrote:
> commit 94647a30124e2c7 ("ARM: dts: omap3-overo: Enable WiFi/BT combo")
> while enabling WiFi/BT combo added regulator to trigger the nReset
> signal of the Bluetooth module in vqmmc-supply. However BT should be
> handled by UART. Moreover "vqmmc" is not a defined binding for
> omap_hsmmc. While "vqmmc" in mmc2 hasn't caused any issues so far,
> mmc2 will start to mis-behave once omap_hsmmc defines "vqmmc"
> binding.
>
> Remove "vqmmc-supply" property in mmc2 here.
>
> Signed-off-by: Kishon Vijay Abraham I <kishon@...com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>  arch/arm/boot/dts/omap3-overo-base.dtsi | 11 -----------
>  1 file changed, 11 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap3-overo-base.dtsi b/arch/arm/boot/dts/omap3-overo-base.dtsi
> index 401fae838fe9..cd220342a805 100644
> --- a/arch/arm/boot/dts/omap3-overo-base.dtsi
> +++ b/arch/arm/boot/dts/omap3-overo-base.dtsi
> @@ -74,16 +74,6 @@
>                 gpio = <&gpio1 16 GPIO_ACTIVE_HIGH>;            /* gpio_16: WiFi nReset */
>                 startup-delay-us = <10000>;
>         };
> -
> -       /* Regulator to trigger the nReset signal of the Bluetooth module */
> -       w3cbw003c_bt_nreset: regulator-w3cbw003c-bt-nreset {
> -               compatible = "regulator-fixed";
> -               regulator-name = "regulator-w3cbw003c-bt-nreset";
> -               regulator-min-microvolt = <3300000>;
> -               regulator-max-microvolt = <3300000>;
> -               gpio = <&gpio6 4 GPIO_ACTIVE_HIGH>;             /* gpio_164: BT nReset */
> -               startup-delay-us = <10000>;
> -       };
>  };
>
>  &omap3_pmx_core {
> @@ -191,7 +181,6 @@
>         pinctrl-names = "default";
>         pinctrl-0 = <&mmc2_pins>;
>         vmmc-supply = <&w3cbw003c_npoweron>;
> -       vqmmc-supply = <&w3cbw003c_bt_nreset>;
>         vmmc_aux-supply = <&w3cbw003c_wifi_nreset>;
>         bus-width = <4>;
>         cap-sdio-irq;
> --
> 2.11.0
>