linux-kernel - Re: [PATCH 1/3] ARM: dts: omap4: add missing des

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Jun 2017 11:14:15 +0300
From:   Tero Kristo <t-kristo@...com>
To:     Sebastian Reichel <sre@...nel.org>,
        Tony Lindgren <tony@...mide.com>,
        Paul Walmsley <paul@...an.com>,
        Benoît Cousson <bcousson@...libre.com>
CC:     <linux-omap@...r.kernel.org>, Russell King <linux@...linux.org.uk>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] ARM: dts: omap4: add missing des_fck

On 10/06/17 02:12, Sebastian Reichel wrote:
> Add missing functional clock for DES3DES IP core. This is
> documented in the TRM as CM_L4SEC_DES3DES_CLKCTRL.
> 
> Signed-off-by: Sebastian Reichel <sre@...nel.org>
> ---
>   arch/arm/boot/dts/omap44xx-clocks.dtsi | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/omap44xx-clocks.dtsi b/arch/arm/boot/dts/omap44xx-clocks.dtsi
> index 9573b37fbaa7..e997265460d4 100644
> --- a/arch/arm/boot/dts/omap44xx-clocks.dtsi
> +++ b/arch/arm/boot/dts/omap44xx-clocks.dtsi
> @@ -985,6 +985,14 @@
>   		reg = <0x15a8>;
>   	};
>   
> +	des_fck: des_fck@...0 {
> +		#clock-cells = <0>;
> +		compatible = "ti,gate-clock";
> +		clocks = <&l3_div_ck>;
> +		ti,bit-shift = <1>;
> +		reg = <0x15b0>;
> +	};
> +
>   	dss_sys_clk: dss_sys_clk@...0 {
>   		#clock-cells = <0>;
>   		compatible = "ti,gate-clock";
> 

NAK. Don't add a duplicate entry for the hwmod clkctrl clock. You are 
adding control to the exact same bit via the hwmod data entry also 
causing a possibility for race condition.

-Tero