linux-kernel - Re: [PATCH v4] mfd: lp87565: Add lp87565 PMIC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABxcv=nHOtGtwpt+fAMtHf6DpAzerxoho45yCJiJoS8cP-0c4Q@mail.gmail.com>
Date:   Mon, 12 Jun 2017 11:27:09 +0200
From:   Javier Martinez Canillas <javier@...hile0.org>
To:     Keerthy <j-keerthy@...com>
Cc:     Lee Jones <lee.jones@...aro.org>, Rob Herring <robh@...nel.org>,
        Mark Brown <broonie@...nel.org>,
        "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
        Linux Kernel <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH v4] mfd: lp87565: Add lp87565 PMIC support

Hello Lee and Keerthy,

On Mon, Jun 12, 2017 at 11:17 AM, Keerthy <j-keerthy@...com> wrote:
>
>
> On Monday 12 June 2017 02:41 PM, Lee Jones wrote:
>> On Sun, 11 Jun 2017, Keerthy wrote:
>>
>>>
>>>
>>> On Sunday 11 June 2017 10:36 AM, Keerthy wrote:
>>>>
>>>>
>>>> On Friday 09 June 2017 07:58 PM, Rob Herring wrote:
>>>>> On Thu, Jun 08, 2017 at 09:38:14AM +0530, Keerthy wrote:
>>>>>> The LP87565 chip is a power management IC for Portable Navigation Systems
>>>>>> and Tablet Computing devices. It contains the following components:
>>>>>>
>>>>>>         - Configurable Bucks(Single and multi-phase).
>>>>>>         - Configurable General Purpose Output Signals (GPO).
>>>>>>
>>>>>> The LP87565-Q1 variant device uses two 2-phase outputs configuration,
>>>>>> Buck0 is master for Buck0/1 output and Buck2 is master for Buck2/3
>>>>>> output.
>>>>>>
>>>
>>> Lee Jones,
>>>
>>> Shall i add back i2c_device_id as pointed here:
>>> http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1417316.html
>>
>> Hasn't that been fixed yet?
>>

There are only 2 patch series remaining to be merged so we can finally
fix this in the I2C core, making sure that no drivers will be
regressed. One of the series is for MFD and have been around for a
while (it already contains all the relevant acks AFAICT), it would be
very helpful if you can look at it and merge if you think is correct:

https://lkml.org/lkml/2017/5/4/11

>> I guess so then. :(
>
> Okay. So with that i assume i should reintroduce probe instead of probe_new.
>

It's orthogonal, you can have probe_new and also the I2C device ID
table (the OF table will be used for matching, you just need the I2C
table to export the aliases with MODULE_DEVICE_TABLE(i2c,.. ).

Best regards,
Javier