linux-kernel - Re: [PATCH 3/3] staging: rtl8188eu: Shorten lines over 80 chars

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170612133557.k6hrnw4yjl4yb4ab@mwanda>
Date:   Mon, 12 Jun 2017 16:35:57 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Aviya Erenfeld <aviyae42@...il.com>
Cc:     gregkh@...uxfoundation.org, goudapatilk@...il.com,
        insafonov@...il.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] staging: rtl8188eu: Shorten lines over 80 chars

On Mon, Jun 12, 2017 at 04:16:18PM +0300, Aviya Erenfeld wrote:
> From: Aviya Erenfeld <aviyae42@...il.com>

No need for this, your email is set up correctly so it works fine as-is.

> 
> Shorten lines over 80 chars
> 
> Signed-off-by: Aviya Erenfeld <aviyae42@...il.com>
> ---
>  drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 58 +++++++++++++++++++---------
>  1 file changed, 39 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> index cd348ca..c924c9e 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> @@ -68,7 +68,8 @@ u32    _rtw_init_sta_priv(struct    sta_priv *pstapriv)
>      struct sta_info *psta;
>      s32 i;
>  
> -    pstapriv->pallocated_stainfo_buf = vzalloc(sizeof(struct sta_info) * NUM_STA + 4);
> +    pstapriv->pallocated_stainfo_buf = vzalloc(sizeof(struct sta_info) *
> +                           NUM_STA + 4);

None of these are aligned correctly.  Run checkpatch.pl --strict over
your patch.  It should be something like:

	pstapriv->pallocated_stainfo_buf = vzalloc(sizeof(struct sta_info) *
						   NUM_STA + 4);

Also the patch is corrupted and doesn't apply.  Read
Documentation/process/email-clients.rst

regards,
dan carpenter