linux-kernel - Re: [PATCH v5 1/6] asm-generic/bug.h: declare struct pt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20489607-25ef-1cbc-3679-6d4c7253514b@mev.co.uk>
Date:   Mon, 12 Jun 2017 15:13:54 +0100
From:   Ian Abbott <abbotti@....co.uk>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
        Alexander Potapenko <glider@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Arnd Bergmann <arnd@...db.de>, Borislav Petkov <bp@...e.de>,
        Hidehiro Kawai <hidehiro.kawai.ez@...achi.com>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Johannes Berg <johannes.berg@...el.com>,
        Kees Cook <keescook@...omium.org>,
        Michal Nazarewicz <mina86@...a86.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Rasmus Villemoes <linux@...musvillemoes.dk>
Subject: Re: [PATCH v5 1/6] asm-generic/bug.h: declare struct pt_regs; before
 function prototype

On 08/06/17 15:07, Steven Rostedt wrote:
> On Thu, 25 May 2017 13:03:11 +0100
> Ian Abbott <abbotti@....co.uk> wrote:
>
>> The declaration of `__warn()` has `struct pt_regs *regs` as one of its
>> parameters.  This can result in compiler warnings if `struct regs` is
>> not already declared.  Add an empty declaration of `struct pt_regs` to
>> avoid the warnings.
>>
>
> Not sure if this has been pulled already or not, but I have a small nit.

It's already in linux-next master.

>
>> Signed-off-by: Ian Abbott <abbotti@....co.uk>
>> Cc: Arnd Bergmann <arnd@...db.de>
>> Acked-by: Arnd Bergmann <arnd@...db.de>
>> Acked-by: Michal Nazarewicz <mina86@...a86.com>
>> ---
>> v3: Actually, there was no v1 or v2.  I called this v3 to match the
>> series.
>> v4: Corrected 'Acked-by:' line in patch description.
>> v5: Added Acked-by for Michal Nazarewicz.
>> ---
>>  include/asm-generic/bug.h | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h
>> index d6f4aed479a1..87191357d303 100644
>> --- a/include/asm-generic/bug.h
>> +++ b/include/asm-generic/bug.h
>> @@ -97,6 +97,7 @@ extern void warn_slowpath_null(const char *file, const int line);
>>
>>  /* used internally by panic.c */
>>  struct warn_args;
>> +struct pt_regs;
>
> Probably be better to move pt_regs above the comment. For one, it is
> used before warn_args in the function below. Two, it's not defined
> internally by panic.c like warn_args is.

Alternatively, the comment could be placed on the same line as `struct 
warn_args;`.  I don't think it's a big enough of a deal to patch it for 
the sake of it, tbh.

>
> -- Steve
>
>
>>
>>  void __warn(const char *file, int line, void *caller, unsigned taint,
>>  	    struct pt_regs *regs, struct warn_args *args);
>


-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-