linux-kernel - Re: [PATCH 2/2] ARM: dts: imx6ul: Add imx6ul-tempmon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Jun 2017 11:30:41 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Lothar Waßmann <LW@...o-electronics.de>
Cc:     Leonard Crestez <leonard.crestez@....com>,
        Bai Ping <ping.bai@....com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Eduardo Valentin <edubezval@...il.com>,
        Sascha Hauer <kernel@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        Zhang Rui <rui.zhang@...el.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 2/2] ARM: dts: imx6ul: Add imx6ul-tempmon

On Mon, Jun 12, 2017 at 10:37 AM, Lothar Waßmann <LW@...o-electronics.de> wrote:
> Hi,
>
> On Mon, 12 Jun 2017 10:22:45 -0300 Fabio Estevam wrote:
>> On Mon, Jun 12, 2017 at 8:47 AM, Leonard Crestez
>> <leonard.crestez@....com> wrote:
>>
>> > However it seems that this might be accidental, it just happens that
>> > the OCOTP clock starts as enabled and is only disabled later in the
>>
>> Most likely because U-Boot enabled the OCOTP clock as it reads the
>> speed grading fuse.
>>
> No, the imx6q_opp_check_speed_grading() runs on an i.MX6Q which, as
> mentioned in my other mail <20170612124029.1643469d@...o-electronics.de>,
> does not require any clock to be enabled for accessing the OCOTP regs.

[Sorry I removed the list in my previous response by mistake]

What I was trying to say is that the OCOTP clock is enabled by U-Boot
on mx6ul evk board.

Please check:
http://git.denx.de/?p=u-boot.git;a=blob;f=board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c;h=a5746fe08688d5752bf1d69cff465a355404d6da;hb=HEAD#l833

This would explain why Leonard did not see the kernel hang on his test.

So I agree with you that the thermal driver needs the IMX6UL_CLK_OCOTP too.