linux-kernel - Re: [PATCH] gpio: lp87565: Add support for GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <167f263d-b339-10e0-8ae2-3dea11874894@ti.com>
Date:   Mon, 12 Jun 2017 20:01:15 +0530
From:   Keerthy <j-keerthy@...com>
To:     Linus Walleij <linus.walleij@...aro.org>
CC:     Lee Jones <lee.jones@...aro.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        Tero Kristo <t-kristo@...com>,
        Linux-OMAP <linux-omap@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Andrew F. Davis" <afd@...com>
Subject: Re: [PATCH] gpio: lp87565: Add support for GPIO



On Monday 12 June 2017 07:34 PM, Linus Walleij wrote:
> On Sun, Jun 11, 2017 at 6:27 AM, Keerthy <j-keerthy@...com> wrote:
>> On Friday 09 June 2017 02:06 PM, Linus Walleij wrote:
> 
>>> If this IC has several function modes for the pins it should also
>>> be a pin controller... I know it is a lot of upfront code, but... it will
>>> benefit you in the long run. Is it really just these three pins?
>>>
>>> Maybe we should merge it into
>>> drivers/pinctrl/pinctrl-lp87565.c so that at least file placement does
>>> not become a problem later?
>>
>> No Linus. Only 2 modes. So went along the lines of
>> drivers/gpio/gpio-lp873x.c. If you are not okay with this. I can as well
>> remove this part.
> 
> It's fine. Sometimes implementing things strictly in very generic frameworks
> will become a burden because of unnecessary complexities.
> 
> Can you just document it with some comments so it is clear what
> is happening here and what the two modes are? And keep it like this
> otherwise.

Okay sure. I will do that in v2.

Thanks,
Keerthy

> 
> Yours,
> Linus Walleij
>