linux-kernel - Re: [PATCH v6 12/12] gpio: dt-bindings: add bindings for Rockchip RK805 PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170612155831.we2p6uxjy4nyblsk@rob-hp-laptop>
Date:   Mon, 12 Jun 2017 10:58:31 -0500
From:   Rob Herring <robh@...nel.org>
To:     Jianhong Chen <chenjh@...k-chips.com>
Cc:     gnurou@...il.com, linus.walleij@...aro.org,
        dmitry.torokhov@...il.com, linux-rockchip@...ts.infradead.org,
        linux-kernel@...r.kernel.org, huangtao@...k-chips.com,
        tony.xie@...k-chips.com, zhangqing@...k-chips.com,
        devicetree@...r.kernel.org, w.egorov@...tec.de,
        lgirdwood@...il.com, broonie@...nel.org, mark.rutland@....com,
        linux-gpio@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH v6 12/12] gpio: dt-bindings: add bindings for Rockchip
 RK805 PMIC

On Thu, Jun 08, 2017 at 03:33:13PM +0800, Jianhong Chen wrote:
> From: chenjh <chenjh@...k-chips.com>
> 
> Add device tree bindings documentation for Rockchip's RK805 PMIC
> 
> Signed-off-by: chenjh <chenjh@...k-chips.com>
> ---
>  .../devicetree/bindings/gpio/gpio-rk805.txt        | 37 ++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/gpio/gpio-rk805.txt
> 
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-rk805.txt b/Documentation/devicetree/bindings/gpio/gpio-rk805.txt
> new file mode 100644
> index 0000000..98b75fa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/gpio-rk805.txt
> @@ -0,0 +1,37 @@
> +RK805 GPIO controller
> +
> +This driver follows the usual GPIO bindings found in
> +Documentation/devicetree/bindings/gpio/gpio.txt
> +
> +Required properties:
> +- #gpio-cells: Should be two. The first cell is the pin number and the
> +  second is the GPIO flags.
> +- gpio-controller: Marks the device node as a GPIO controller.
> +
> +These properties must be added in the RK805 PMIC node, documented in
> +Documentation/devicetree/bindings/mfd/rk808.txt
> +
> +Example:
> +
> +rk805: pmic@18 {
> +	compatible = "rockchip,rk808";
> +	clock-output-names = "xin32k", "rk808-clkout2";
> +	interrupt-parent = <&gpio0>;
> +	interrupts = <4 IRQ_TYPE_LEVEL_LOW>;
> +	reg = <0x1a>;
> +	rockchip,system-power-controller;
> +	wakeup-source;
> +	#clock-cells = <1>;
> +	...
> +	gpio-controller;
> +	#gpio-cells = <2>;
> +};
> +
> +
> +Example of a peripheral using the PMIC GPIOs:
> +
> +wireless-bluetooth {
> +		compatible = "bluetooth-platdata";

Not a valid example compatible. While you don't really have to have a 
valid one, it should be something that's not a "what not to do" and 
would never be accepted.

Rob