linux-kernel - Re: [net-next] net: phy: marvell: Show complete link partner advertising

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a172b1f9-5141-6d53-1d96-bd028a0b0a23@gmail.com>
Date:   Mon, 12 Jun 2017 09:05:04 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>, andrew@...n.ch,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        rmk+kernel@...linux.org.uk
Subject: Re: [net-next] net: phy: marvell: Show complete link partner
 advertising

On 06/12/2017 05:54 AM, Thomas Bogendoerfer wrote:
> From: Thomas Bogendoerfer <tbogendoerfer@...e.de>
> 
> Give back all modes advertised by the link partner. This change brings
> the marvell phy driver in line with all other phy drivers.
> 
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@...e.de>

I thought Russell had a similar patch but I can't find it applied in
net-next, so:

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

drivers/net/phy/lxt.c has a similar pattern that would be worth fixing too.

> ---
>  drivers/net/phy/marvell.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
> index 4c5246fed69b..8400403b3f62 100644
> --- a/drivers/net/phy/marvell.c
> +++ b/drivers/net/phy/marvell.c
> @@ -1139,7 +1139,6 @@ static int marvell_read_status_page_an(struct phy_device *phydev,
>  	int status;
>  	int lpa;
>  	int lpagb;
> -	int adv;
>  
>  	status = phy_read(phydev, MII_M1011_PHY_STATUS);
>  	if (status < 0)
> @@ -1153,12 +1152,6 @@ static int marvell_read_status_page_an(struct phy_device *phydev,
>  	if (lpagb < 0)
>  		return lpagb;
>  
> -	adv = phy_read(phydev, MII_ADVERTISE);
> -	if (adv < 0)
> -		return adv;
> -
> -	lpa &= adv;
> -
>  	if (status & MII_M1011_PHY_STATUS_FULLDUPLEX)
>  		phydev->duplex = DUPLEX_FULL;
>  	else
> 


-- 
Florian