linux-kernel - Re: [PATCH 1/2] cpuidle: dt: Add missing 'of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Jun 2017 17:42:40 +0100
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     rjw@...ysocki.net, linux-pm@...r.kernel.org,
        Christophe Jaillet <christophe.jaillet@...adoo.fr>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] cpuidle: dt: Add missing 'of_node_put()'

On Mon, Jun 12, 2017 at 05:55:09PM +0200, Daniel Lezcano wrote:
> From: Christophe Jaillet <christophe.jaillet@...adoo.fr>
> 
> 'of_node_put()' should be called on pointer returned by
> 'of_parse_phandle()' when done. In this function this is done in all path
> except this 'continue', so add it.
> 
> Fixes: 97735da074fd ("drivers: cpuidle: Add status property to ARM idle states")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>

Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@....com>

> ---
>  drivers/cpuidle/dt_idle_states.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/cpuidle/dt_idle_states.c b/drivers/cpuidle/dt_idle_states.c
> index ffca4fc..ae8eb03 100644
> --- a/drivers/cpuidle/dt_idle_states.c
> +++ b/drivers/cpuidle/dt_idle_states.c
> @@ -180,8 +180,10 @@ int dt_init_idle_driver(struct cpuidle_driver *drv,
>  		if (!state_node)
>  			break;
>  
> -		if (!of_device_is_available(state_node))
> +		if (!of_device_is_available(state_node)) {
> +			of_node_put(state_node);
>  			continue;
> +		}
>  
>  		if (!idle_state_valid(state_node, i, cpumask)) {
>  			pr_warn("%s idle state not valid, bailing out\n",
> -- 
> 2.7.4
>