linux-kernel - Re: [PATCH v10 09/10] powerpc/perf: Thread IMC PMU functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <3b50b153-147f-bd0b-4d00-cdc538d4ca10@linux.vnet.ibm.com>
Date:   Mon, 12 Jun 2017 11:50:09 +0530
From:   Madhavan Srinivasan <maddy@...ux.vnet.ibm.com>
To:     kbuild test robot <lkp@...el.com>
Cc:     kbuild-all@...org, mpe@...erman.id.au,
        linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        stewart@...ux.vnet.ibm.com, eranian@...gle.com,
        benh@...nel.crashing.org, paulus@...ba.org,
        sukadev@...ux.vnet.ibm.com, ego@...ux.vnet.ibm.com,
        mikey@...ling.org, dja@...ens.net, anton@...ba.org,
        Anju T Sudhakar <anju@...ux.vnet.ibm.com>,
        Hemant Kumar <hemant@...ux.vnet.ibm.com>
Subject: Re: [PATCH v10 09/10] powerpc/perf: Thread IMC PMU functions



On Sunday 11 June 2017 01:43 AM, kbuild test robot wrote:
> Hi Anju,
>
> [auto build test ERROR on powerpc/next]
> [also build test ERROR on v4.12-rc4 next-20170609]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url:    https://github.com/0day-ci/linux/commits/Madhavan-Srinivasan/IMC-Instrumentation-Support/20170609-183528
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
> config: powerpc-defconfig (attached as .config)
> compiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
> reproduce:
>          wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>          chmod +x ~/bin/make.cross
>          # save the attached .config to linux build tree
>          make.cross ARCH=powerpc
>
> Note: the linux-review/Madhavan-Srinivasan/IMC-Instrumentation-Support/20170609-183528 HEAD 32ada0705ff79986e8ceca5e83dba14c0b620751 builds fine.
>        It only hurts bisectibility.
>
> All errors (new ones prefixed by >>):
>
>     In file included from include/linux/compiler.h:62:0,
>                      from include/uapi/linux/stddef.h:1,
>                      from include/linux/stddef.h:4,
>                      from include/uapi/linux/posix_types.h:4,
>                      from include/uapi/linux/types.h:13,
>                      from include/linux/types.h:5,
>                      from include/uapi/linux/perf_event.h:17,
>                      from include/linux/perf_event.h:17,
>                      from arch/powerpc/perf/imc-pmu.c:13:
>     arch/powerpc/perf/imc-pmu.c: In function 'cleanup_all_thread_imc_memory':
>>> arch/powerpc/perf/imc-pmu.c:863:31: error: 'cpu' undeclared (first use in this function)
Have fixed this issue in the next patch. Damn my bad.
Will wait for comments and if needed can respin just with this.

Maddy

>        if (per_cpu(thread_imc_mem, cpu))
>                                    ^
>     include/linux/compiler-gcc.h:53:26: note: in definition of macro 'RELOC_HIDE'
>       (typeof(ptr)) (__ptr + (off));     \
>                               ^~~
>     include/linux/percpu-defs.h:223:2: note: in expansion of macro 'SHIFT_PERCPU_PTR'
>       SHIFT_PERCPU_PTR((ptr), per_cpu_offset((cpu)));   \
>       ^~~~~~~~~~~~~~~~
>     include/linux/percpu-defs.h:223:26: note: in expansion of macro 'per_cpu_offset'
>       SHIFT_PERCPU_PTR((ptr), per_cpu_offset((cpu)));   \
>                               ^~~~~~~~~~~~~~
>     include/linux/percpu-defs.h:256:29: note: in expansion of macro 'per_cpu_ptr'
>      #define per_cpu(var, cpu) (*per_cpu_ptr(&(var), cpu))
>                                  ^~~~~~~~~~~
>     arch/powerpc/perf/imc-pmu.c:863:7: note: in expansion of macro 'per_cpu'
>        if (per_cpu(thread_imc_mem, cpu))
>            ^~~~~~~
>     arch/powerpc/perf/imc-pmu.c:863:31: note: each undeclared identifier is reported only once for each function it appears in
>        if (per_cpu(thread_imc_mem, cpu))
>                                    ^
>     include/linux/compiler-gcc.h:53:26: note: in definition of macro 'RELOC_HIDE'
>       (typeof(ptr)) (__ptr + (off));     \
>                               ^~~
>     include/linux/percpu-defs.h:223:2: note: in expansion of macro 'SHIFT_PERCPU_PTR'
>       SHIFT_PERCPU_PTR((ptr), per_cpu_offset((cpu)));   \
>       ^~~~~~~~~~~~~~~~
>     include/linux/percpu-defs.h:223:26: note: in expansion of macro 'per_cpu_offset'
>       SHIFT_PERCPU_PTR((ptr), per_cpu_offset((cpu)));   \
>                               ^~~~~~~~~~~~~~
>     include/linux/percpu-defs.h:256:29: note: in expansion of macro 'per_cpu_ptr'
>      #define per_cpu(var, cpu) (*per_cpu_ptr(&(var), cpu))
>                                  ^~~~~~~~~~~
>     arch/powerpc/perf/imc-pmu.c:863:7: note: in expansion of macro 'per_cpu'
>        if (per_cpu(thread_imc_mem, cpu))
>            ^~~~~~~
>
> vim +/cpu +863 arch/powerpc/perf/imc-pmu.c
>
>     857	
>     858	static void cleanup_all_thread_imc_memory(void)
>     859	{
>     860		int i;
>     861	
>     862		for_each_online_cpu(i) {
>   > 863			if (per_cpu(thread_imc_mem, cpu))
>     864				free_pages(per_cpu(thread_imc_mem, cpu), 0);
>     865		}
>     866	}
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation