lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 13 Jun 2017 16:53:03 -0700 From: Stephen Hemminger <stephen@...workplumber.org> To: Salil Mehta <salil.mehta@...wei.com> Cc: <davem@...emloft.net>, <yisen.zhuang@...wei.com>, <huangdaode@...ilicon.com>, <lipeng321@...wei.com>, <mehta.salil.lnk@...il.com>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <linuxarm@...wei.com> Subject: Re: [PATCH V2 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC On Wed, 14 Jun 2017 00:10:28 +0100 Salil Mehta <salil.mehta@...wei.com> wrote: > +static irqreturn_t hns3_irq_handle(int irq, void *dev) > +{ > + struct hns3_enet_tqp_vector *tqp_vector = dev; > + > + napi_schedule(&tqp_vector->napi); In order to do NAPI correctly, the IRQ must be disabled. If you are using MSI, then hardware will do it for you. But I don't see you ever enable MSI or MSI-x in this driver. Are you just assuming that the driver only works on one platform and that platform has PCI MSI-X?
Powered by blists - more mailing lists