lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b990a86b-765b-b826-246f-bba99d156ada@codeaurora.org>
Date:   Tue, 13 Jun 2017 10:50:40 +0530
From:   Varadarajan Narayanan <varada@...eaurora.org>
To:     bjorn.andersson@...aro.org, robh+dt@...nel.org,
        mark.rutland@....com, mturquette@...libre.com,
        sboyd@...eaurora.org, linus.walleij@...aro.org,
        andy.gross@...aro.org, david.brown@...aro.org,
        catalin.marinas@....com, will.deacon@....com,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Cc:     absahu@...eaurora.org, sjaganat@...eaurora.org,
        sricharan@...eaurora.org,
        Manoharan Vijaya Raghavan <mraghava@...eaurora.org>
Subject: Re: [PATCH v6 1/6] pinctrl: qcom: Add ipq8074 pinctrl driver

Bjorn,

On 6/9/2017 3:11 PM, Varadarajan Narayanan wrote:
> Add initial pinctrl driver to support pin configuration with
> pinctrl framework for ipq8074.
> 
> Acked-by: Rob Herring <robh@...nel.org> (bindings)
> Signed-off-by: Manoharan Vijaya Raghavan <mraghava@...eaurora.org>
> Signed-off-by: Varadarajan Narayanan <varada@...eaurora.org>
> ---
>   .../bindings/pinctrl/qcom,ipq8074-pinctrl.txt      |  172 ++++
>   drivers/pinctrl/qcom/Kconfig                       |   10 +
>   drivers/pinctrl/qcom/Makefile                      |    1 +
>   drivers/pinctrl/qcom/pinctrl-ipq8074.c             | 1076 ++++++++++++++++++++
>   4 files changed, 1259 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,ipq8074-pinctrl.txt
>   create mode 100644 drivers/pinctrl/qcom/pinctrl-ipq8074.c
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,ipq8074-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,ipq8074-pinctrl.txt
> new file mode 100644
> index 0000000..407b944
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,ipq8074-pinctrl.txt
> @@ -0,0 +1,172 @@
> +Qualcomm Technologies, Inc. IPQ8074 TLMM block
> +
> +This binding describes the Top Level Mode Multiplexer block found in the
> +IPQ8074 platform.
> +
> +- compatible:
> +	Usage: required
> +	Value type: <string>
> +	Definition: must be "qcom,ipq8074-pinctrl"
> +
> +- reg:
> +	Usage: required
> +	Value type: <prop-encoded-array>
> +	Definition: the base address and size of the TLMM register space.
> +
> +- interrupts:
> +	Usage: required
> +	Value type: <prop-encoded-array>
> +	Definition: should specify the TLMM summary IRQ.
> +
> +- interrupt-controller:
> +	Usage: required
> +	Value type: <none>
> +	Definition: identifies this node as an interrupt controller
> +
> +- #interrupt-cells:
> +	Usage: required
> +	Value type: <u32>
> +	Definition: must be 2. Specifying the pin number and flags, as defined
> +		    in <dt-bindings/interrupt-controller/irq.h>
> +
> +- gpio-controller:
> +	Usage: required
> +	Value type: <none>
> +	Definition: identifies this node as a gpio controller
> +
> +- #gpio-cells:
> +	Usage: required
> +	Value type: <u32>
> +	Definition: must be 2. Specifying the pin number and flags, as defined
> +		    in <dt-bindings/gpio/gpio.h>
> +
> +Please refer to ../gpio/gpio.txt and ../interrupt-controller/interrupts.txt for
> +a general description of GPIO and interrupt bindings.
> +
> +Please refer to pinctrl-bindings.txt in this directory for details of the
> +common pinctrl bindings used by client devices, including the meaning of the
> +phrase "pin configuration node".
> +
> +The pin configuration nodes act as a container for an arbitrary number of
> +subnodes. Each of these subnodes represents some desired configuration for a
> +pin, a group, or a list of pins or groups. This configuration can include the
> +mux function to select on those pin(s)/group(s), and various pin configuration
> +parameters, such as pull-up, drive strength, etc.
> +
> +
> +PIN CONFIGURATION NODES:
> +
> +The name of each subnode is not important; all subnodes should be enumerated
> +and processed purely based on their content.
> +
> +Each subnode only affects those parameters that are explicitly listed. In
> +other words, a subnode that lists a mux function but no pin configuration
> +parameters implies no information about any pin configuration parameters.
> +Similarly, a pin subnode that describes a pullup parameter implies no
> +information about e.g. the mux function.
> +
> +
> +The following generic properties as defined in pinctrl-bindings.txt are valid
> +to specify in a pin configuration subnode:
> +
> +- pins:
> +	Usage: required
> +	Value type: <string-array>
> +	Definition: List of gpio pins affected by the properties specified in
> +		    this subnode.  Valid pins are:
> +		    gpio0-gpio69
> +
> +- function:
> +	Usage: required
> +	Value type: <string>
> +	Definition: Specify the alternative function to be configured for the
> +		    specified pins. Functions are only valid for gpio pins.
> +		    Valid values are:
> +		    atest_char, atest_char0, atest_char1, atest_char2,
> +		    atest_char3, audio_rxbclk, audio_rxd, audio_rxfsync,
> +		    audio_rxmclk, audio_txbclk, audio_txd, audio_txfsync,
> +		    audio_txmclk, blsp0_i2c, blsp0_spi, blsp0_uart, blsp1_i2c,
> +		    blsp1_spi, blsp1_uart, blsp2_i2c, blsp2_spi, blsp2_uart,
> +		    blsp3_i2c, blsp3_spi, blsp3_spi0, blsp3_spi1, blsp3_spi2,
> +		    blsp3_spi3, blsp3_uart, blsp4_i2c0, blsp4_i2c1, blsp4_spi0,
> +		    blsp4_spi1, blsp4_uart0, blsp4_uart1, blsp5_i2c, blsp5_spi,
> +		    blsp5_uart, burn0, burn1, cri_trng, cri_trng0, cri_trng1,
> +		    cxc0, cxc1, dbg_out, gcc_plltest, gcc_tlmm, gpio, ldo_en,
> +		    ldo_update, led0, led1, led2, mac0_sa0, mac0_sa1, mac1_sa0,
> +		    mac1_sa1, mac1_sa2, mac1_sa3, mac2_sa0, mac2_sa1, mdc,
> +		    mdio, pcie0_clk, pcie0_rst, pcie0_wake, pcie1_clk,
> +		    pcie1_rst, pcie1_wake, pcm_drx, pcm_dtx, pcm_fsync,
> +		    pcm_pclk, pcm_zsi0, pcm_zsi1, prng_rosc, pta1_0, pta1_1,
> +		    pta1_2, pta2_0, pta2_1, pta2_2, pwm0, pwm1, pwm2, pwm3,
> +		    qdss_cti_trig_in_a0, qdss_cti_trig_in_a1,
> +		    qdss_cti_trig_in_b0, qdss_cti_trig_in_b1,
> +		    qdss_cti_trig_out_a0, qdss_cti_trig_out_a1,
> +		    qdss_cti_trig_out_b0, qdss_cti_trig_out_b1,
> +		    qdss_traceclk_a, qdss_traceclk_b, qdss_tracectl_a,
> +		    qdss_tracectl_b, qdss_tracedata_a, qdss_tracedata_b,
> +		    qpic, rx0, rx1, rx2, sd_card, sd_write, tsens_max, wci2a,
> +		    wci2b, wci2c, wci2d
> +
> +- bias-disable:
> +	Usage: optional
> +	Value type: <none>
> +	Definition: The specified pins should be configued as no pull.
> +
> +- bias-pull-down:
> +	Usage: optional
> +	Value type: <none>
> +	Definition: The specified pins should be configued as pull down.
> +
> +- bias-pull-up:
> +	Usage: optional
> +	Value type: <none>
> +	Definition: The specified pins should be configued as pull up.
> +
> +- output-high:
> +	Usage: optional
> +	Value type: <none>
> +	Definition: The specified pins are configured in output mode, driven
> +		    high.
> +
> +- output-low:
> +	Usage: optional
> +	Value type: <none>
> +	Definition: The specified pins are configured in output mode, driven
> +		    low.
> +
> +- drive-strength:
> +	Usage: optional
> +	Value type: <u32>
> +	Definition: Selects the drive strength for the specified pins, in mA.
> +		    Valid values are: 2, 4, 6, 8, 10, 12, 14 and 16
> +
> +Example:
> +
> +	tlmm: pinctrl@...0000 {
> +		compatible = "qcom,ipq8074-pinctrl";
> +		reg = <0x1000000 0x300000>;
> +		interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +		interrupt-controller;
> +		#interrupt-cells = <2>;
> +
> +		uart2: uart2-default {
> +			mux {
> +				pins = "gpio23", "gpio24";
> +				function = "blsp4_uart1";
> +			};
> +
> +			rx {
> +				pins = "gpio23";
> +				drive-strength = <4>;
> +				bias-disable;
> +			};
> +
> +			tx {
> +				pins = "gpio24";
> +				drive-strength = <2>;
> +				bias-pull-up;
> +			};
> +		};
> +	};
> diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfig
> index 3ebdc01..9e504db 100644
> --- a/drivers/pinctrl/qcom/Kconfig
> +++ b/drivers/pinctrl/qcom/Kconfig
> @@ -39,6 +39,16 @@ config PINCTRL_IPQ8064
>   	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
>   	  Qualcomm TLMM block found in the Qualcomm IPQ8064 platform.
>   
> +config PINCTRL_IPQ8074
> +	tristate "Qualcomm Technologies, Inc. IPQ8074 pin controller driver"
> +	depends on GPIOLIB && OF
> +	select PINCTRL_MSM
> +	help
> +	  This is the pinctrl, pinmux, pinconf and gpiolib driver for
> +	  the Qualcomm Technologies Inc. TLMM block found on the
> +	  Qualcomm Technologies Inc. IPQ8074 platform. Select this for
> +	  IPQ8074.
> +
>   config PINCTRL_MSM8660
>   	tristate "Qualcomm 8660 pin controller driver"
>   	depends on GPIOLIB && OF
> diff --git a/drivers/pinctrl/qcom/Makefile b/drivers/pinctrl/qcom/Makefile
> index ab47764..06c8b2a 100644
> --- a/drivers/pinctrl/qcom/Makefile
> +++ b/drivers/pinctrl/qcom/Makefile
> @@ -4,6 +4,7 @@ obj-$(CONFIG_PINCTRL_APQ8064)	+= pinctrl-apq8064.o
>   obj-$(CONFIG_PINCTRL_APQ8084)	+= pinctrl-apq8084.o
>   obj-$(CONFIG_PINCTRL_IPQ4019)	+= pinctrl-ipq4019.o
>   obj-$(CONFIG_PINCTRL_IPQ8064)	+= pinctrl-ipq8064.o
> +obj-$(CONFIG_PINCTRL_IPQ8074)	+= pinctrl-ipq8074.o
>   obj-$(CONFIG_PINCTRL_MSM8660)	+= pinctrl-msm8660.o
>   obj-$(CONFIG_PINCTRL_MSM8960)	+= pinctrl-msm8960.o
>   obj-$(CONFIG_PINCTRL_MSM8X74)	+= pinctrl-msm8x74.o
> diff --git a/drivers/pinctrl/qcom/pinctrl-ipq8074.c b/drivers/pinctrl/qcom/pinctrl-ipq8074.c
> new file mode 100644
> index 0000000..10fb076
> --- /dev/null
> +++ b/drivers/pinctrl/qcom/pinctrl-ipq8074.c
> @@ -0,0 +1,1076 @@
> +/*
> + * Copyright (c) 2017, The Linux Foundation. All rights reserved.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 and
> + * only version 2 as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#include <linux/module.h>
> +#include <linux/of.h>
> +#include <linux/platform_device.h>
> +#include <linux/pinctrl/pinctrl.h>
> +
> +#include "pinctrl-msm.h"
> +
> +#define FUNCTION(fname)			                \
> +	[msm_mux_##fname] = {		                \
> +		.name = #fname,				\
> +		.groups = fname##_groups,               \
> +		.ngroups = ARRAY_SIZE(fname##_groups),	\
> +	}
> +
> +#define REG_SIZE 0x1000
> +#define PINGROUP(id, f1, f2, f3, f4, f5, f6, f7, f8, f9)	\
> +	{					        \
> +		.name = "gpio" #id,			\
> +		.pins = gpio##id##_pins,		\
> +		.npins = (unsigned int)ARRAY_SIZE(gpio##id##_pins),	\
> +		.funcs = (int[]){			\
> +			msm_mux_gpio, /* gpio mode */	\
> +			msm_mux_##f1,			\
> +			msm_mux_##f2,			\
> +			msm_mux_##f3,			\
> +			msm_mux_##f4,			\
> +			msm_mux_##f5,			\
> +			msm_mux_##f6,			\
> +			msm_mux_##f7,			\
> +			msm_mux_##f8,			\
> +			msm_mux_##f9			\
> +		},				        \
> +		.nfuncs = 10,				\
> +		.ctl_reg = REG_SIZE * id,		\
> +		.io_reg = 0x4 + REG_SIZE * id,		\
> +		.intr_cfg_reg = 0x8 + REG_SIZE * id,		\
> +		.intr_status_reg = 0xc + REG_SIZE * id,	\
> +		.intr_target_reg = 0x8 + REG_SIZE * id,	\
> +		.mux_bit = 2,			\
> +		.pull_bit = 0,			\
> +		.drv_bit = 6,			\
> +		.oe_bit = 9,			\
> +		.in_bit = 0,			\
> +		.out_bit = 1,			\
> +		.intr_enable_bit = 0,		\
> +		.intr_status_bit = 0,		\
> +		.intr_target_bit = 5,		\
> +		.intr_raw_status_bit = 4,	\
> +		.intr_polarity_bit = 1,		\
> +		.intr_detection_bit = 2,	\
> +		.intr_detection_width = 2,	\
> +	}
> +
> +static const struct pinctrl_pin_desc ipq8074_pins[] = {
> +	PINCTRL_PIN(0, "GPIO_0"),
> +	PINCTRL_PIN(1, "GPIO_1"),
> +	PINCTRL_PIN(2, "GPIO_2"),
> +	PINCTRL_PIN(3, "GPIO_3"),
> +	PINCTRL_PIN(4, "GPIO_4"),
> +	PINCTRL_PIN(5, "GPIO_5"),
> +	PINCTRL_PIN(6, "GPIO_6"),
> +	PINCTRL_PIN(7, "GPIO_7"),
> +	PINCTRL_PIN(8, "GPIO_8"),
> +	PINCTRL_PIN(9, "GPIO_9"),
> +	PINCTRL_PIN(10, "GPIO_10"),
> +	PINCTRL_PIN(11, "GPIO_11"),
> +	PINCTRL_PIN(12, "GPIO_12"),
> +	PINCTRL_PIN(13, "GPIO_13"),
> +	PINCTRL_PIN(14, "GPIO_14"),
> +	PINCTRL_PIN(15, "GPIO_15"),
> +	PINCTRL_PIN(16, "GPIO_16"),
> +	PINCTRL_PIN(17, "GPIO_17"),
> +	PINCTRL_PIN(18, "GPIO_18"),
> +	PINCTRL_PIN(19, "GPIO_19"),
> +	PINCTRL_PIN(20, "GPIO_20"),
> +	PINCTRL_PIN(21, "GPIO_21"),
> +	PINCTRL_PIN(22, "GPIO_22"),
> +	PINCTRL_PIN(23, "GPIO_23"),
> +	PINCTRL_PIN(24, "GPIO_24"),
> +	PINCTRL_PIN(25, "GPIO_25"),
> +	PINCTRL_PIN(26, "GPIO_26"),
> +	PINCTRL_PIN(27, "GPIO_27"),
> +	PINCTRL_PIN(28, "GPIO_28"),
> +	PINCTRL_PIN(29, "GPIO_29"),
> +	PINCTRL_PIN(30, "GPIO_30"),
> +	PINCTRL_PIN(31, "GPIO_31"),
> +	PINCTRL_PIN(32, "GPIO_32"),
> +	PINCTRL_PIN(33, "GPIO_33"),
> +	PINCTRL_PIN(34, "GPIO_34"),
> +	PINCTRL_PIN(35, "GPIO_35"),
> +	PINCTRL_PIN(36, "GPIO_36"),
> +	PINCTRL_PIN(37, "GPIO_37"),
> +	PINCTRL_PIN(38, "GPIO_38"),
> +	PINCTRL_PIN(39, "GPIO_39"),
> +	PINCTRL_PIN(40, "GPIO_40"),
> +	PINCTRL_PIN(41, "GPIO_41"),
> +	PINCTRL_PIN(42, "GPIO_42"),
> +	PINCTRL_PIN(43, "GPIO_43"),
> +	PINCTRL_PIN(44, "GPIO_44"),
> +	PINCTRL_PIN(45, "GPIO_45"),
> +	PINCTRL_PIN(46, "GPIO_46"),
> +	PINCTRL_PIN(47, "GPIO_47"),
> +	PINCTRL_PIN(48, "GPIO_48"),
> +	PINCTRL_PIN(49, "GPIO_49"),
> +	PINCTRL_PIN(50, "GPIO_50"),
> +	PINCTRL_PIN(51, "GPIO_51"),
> +	PINCTRL_PIN(52, "GPIO_52"),
> +	PINCTRL_PIN(53, "GPIO_53"),
> +	PINCTRL_PIN(54, "GPIO_54"),
> +	PINCTRL_PIN(55, "GPIO_55"),
> +	PINCTRL_PIN(56, "GPIO_56"),
> +	PINCTRL_PIN(57, "GPIO_57"),
> +	PINCTRL_PIN(58, "GPIO_58"),
> +	PINCTRL_PIN(59, "GPIO_59"),
> +	PINCTRL_PIN(60, "GPIO_60"),
> +	PINCTRL_PIN(61, "GPIO_61"),
> +	PINCTRL_PIN(62, "GPIO_62"),
> +	PINCTRL_PIN(63, "GPIO_63"),
> +	PINCTRL_PIN(64, "GPIO_64"),
> +	PINCTRL_PIN(65, "GPIO_65"),
> +	PINCTRL_PIN(66, "GPIO_66"),
> +	PINCTRL_PIN(67, "GPIO_67"),
> +	PINCTRL_PIN(68, "GPIO_68"),
> +	PINCTRL_PIN(69, "GPIO_69"),
> +};
> +
> +#define DECLARE_MSM_GPIO_PINS(pin) \
> +	static const unsigned int gpio##pin##_pins[] = { pin }
> +DECLARE_MSM_GPIO_PINS(0);
> +DECLARE_MSM_GPIO_PINS(1);
> +DECLARE_MSM_GPIO_PINS(2);
> +DECLARE_MSM_GPIO_PINS(3);
> +DECLARE_MSM_GPIO_PINS(4);
> +DECLARE_MSM_GPIO_PINS(5);
> +DECLARE_MSM_GPIO_PINS(6);
> +DECLARE_MSM_GPIO_PINS(7);
> +DECLARE_MSM_GPIO_PINS(8);
> +DECLARE_MSM_GPIO_PINS(9);
> +DECLARE_MSM_GPIO_PINS(10);
> +DECLARE_MSM_GPIO_PINS(11);
> +DECLARE_MSM_GPIO_PINS(12);
> +DECLARE_MSM_GPIO_PINS(13);
> +DECLARE_MSM_GPIO_PINS(14);
> +DECLARE_MSM_GPIO_PINS(15);
> +DECLARE_MSM_GPIO_PINS(16);
> +DECLARE_MSM_GPIO_PINS(17);
> +DECLARE_MSM_GPIO_PINS(18);
> +DECLARE_MSM_GPIO_PINS(19);
> +DECLARE_MSM_GPIO_PINS(20);
> +DECLARE_MSM_GPIO_PINS(21);
> +DECLARE_MSM_GPIO_PINS(22);
> +DECLARE_MSM_GPIO_PINS(23);
> +DECLARE_MSM_GPIO_PINS(24);
> +DECLARE_MSM_GPIO_PINS(25);
> +DECLARE_MSM_GPIO_PINS(26);
> +DECLARE_MSM_GPIO_PINS(27);
> +DECLARE_MSM_GPIO_PINS(28);
> +DECLARE_MSM_GPIO_PINS(29);
> +DECLARE_MSM_GPIO_PINS(30);
> +DECLARE_MSM_GPIO_PINS(31);
> +DECLARE_MSM_GPIO_PINS(32);
> +DECLARE_MSM_GPIO_PINS(33);
> +DECLARE_MSM_GPIO_PINS(34);
> +DECLARE_MSM_GPIO_PINS(35);
> +DECLARE_MSM_GPIO_PINS(36);
> +DECLARE_MSM_GPIO_PINS(37);
> +DECLARE_MSM_GPIO_PINS(38);
> +DECLARE_MSM_GPIO_PINS(39);
> +DECLARE_MSM_GPIO_PINS(40);
> +DECLARE_MSM_GPIO_PINS(41);
> +DECLARE_MSM_GPIO_PINS(42);
> +DECLARE_MSM_GPIO_PINS(43);
> +DECLARE_MSM_GPIO_PINS(44);
> +DECLARE_MSM_GPIO_PINS(45);
> +DECLARE_MSM_GPIO_PINS(46);
> +DECLARE_MSM_GPIO_PINS(47);
> +DECLARE_MSM_GPIO_PINS(48);
> +DECLARE_MSM_GPIO_PINS(49);
> +DECLARE_MSM_GPIO_PINS(50);
> +DECLARE_MSM_GPIO_PINS(51);
> +DECLARE_MSM_GPIO_PINS(52);
> +DECLARE_MSM_GPIO_PINS(53);
> +DECLARE_MSM_GPIO_PINS(54);
> +DECLARE_MSM_GPIO_PINS(55);
> +DECLARE_MSM_GPIO_PINS(56);
> +DECLARE_MSM_GPIO_PINS(57);
> +DECLARE_MSM_GPIO_PINS(58);
> +DECLARE_MSM_GPIO_PINS(59);
> +DECLARE_MSM_GPIO_PINS(60);
> +DECLARE_MSM_GPIO_PINS(61);
> +DECLARE_MSM_GPIO_PINS(62);
> +DECLARE_MSM_GPIO_PINS(63);
> +DECLARE_MSM_GPIO_PINS(64);
> +DECLARE_MSM_GPIO_PINS(65);
> +DECLARE_MSM_GPIO_PINS(66);
> +DECLARE_MSM_GPIO_PINS(67);
> +DECLARE_MSM_GPIO_PINS(68);
> +DECLARE_MSM_GPIO_PINS(69);
> +
> +enum ipq8074_functions {
> +	msm_mux_atest_char,
> +	msm_mux_atest_char0,
> +	msm_mux_atest_char1,
> +	msm_mux_atest_char2,
> +	msm_mux_atest_char3,
> +	msm_mux_audio_rxbclk,
> +	msm_mux_audio_rxd,
> +	msm_mux_audio_rxfsync,
> +	msm_mux_audio_rxmclk,
> +	msm_mux_audio_txbclk,
> +	msm_mux_audio_txd,
> +	msm_mux_audio_txfsync,
> +	msm_mux_audio_txmclk,
> +	msm_mux_blsp0_i2c,
> +	msm_mux_blsp0_spi,
> +	msm_mux_blsp0_uart,
> +	msm_mux_blsp1_i2c,
> +	msm_mux_blsp1_spi,
> +	msm_mux_blsp1_uart,
> +	msm_mux_blsp2_i2c,
> +	msm_mux_blsp2_spi,
> +	msm_mux_blsp2_uart,
> +	msm_mux_blsp3_i2c,
> +	msm_mux_blsp3_spi,
> +	msm_mux_blsp3_spi0,
> +	msm_mux_blsp3_spi1,
> +	msm_mux_blsp3_spi2,
> +	msm_mux_blsp3_spi3,
> +	msm_mux_blsp3_uart,
> +	msm_mux_blsp4_i2c0,
> +	msm_mux_blsp4_i2c1,
> +	msm_mux_blsp4_spi0,
> +	msm_mux_blsp4_spi1,
> +	msm_mux_blsp4_uart0,
> +	msm_mux_blsp4_uart1,
> +	msm_mux_blsp5_i2c,
> +	msm_mux_blsp5_spi,
> +	msm_mux_blsp5_uart,
> +	msm_mux_burn0,
> +	msm_mux_burn1,
> +	msm_mux_cri_trng,
> +	msm_mux_cri_trng0,
> +	msm_mux_cri_trng1,
> +	msm_mux_cxc0,
> +	msm_mux_cxc1,
> +	msm_mux_dbg_out,
> +	msm_mux_gcc_plltest,
> +	msm_mux_gcc_tlmm,
> +	msm_mux_gpio,
> +	msm_mux_ldo_en,
> +	msm_mux_ldo_update,
> +	msm_mux_led0,
> +	msm_mux_led1,
> +	msm_mux_led2,
> +	msm_mux_mac0_sa0,
> +	msm_mux_mac0_sa1,
> +	msm_mux_mac1_sa0,
> +	msm_mux_mac1_sa1,
> +	msm_mux_mac1_sa2,
> +	msm_mux_mac1_sa3,
> +	msm_mux_mac2_sa0,
> +	msm_mux_mac2_sa1,
> +	msm_mux_mdc,
> +	msm_mux_mdio,
> +	msm_mux_pcie0_clk,
> +	msm_mux_pcie0_rst,
> +	msm_mux_pcie0_wake,
> +	msm_mux_pcie1_clk,
> +	msm_mux_pcie1_rst,
> +	msm_mux_pcie1_wake,
> +	msm_mux_pcm_drx,
> +	msm_mux_pcm_dtx,
> +	msm_mux_pcm_fsync,
> +	msm_mux_pcm_pclk,
> +	msm_mux_pcm_zsi0,
> +	msm_mux_pcm_zsi1,
> +	msm_mux_prng_rosc,
> +	msm_mux_pta1_0,
> +	msm_mux_pta1_1,
> +	msm_mux_pta1_2,
> +	msm_mux_pta2_0,
> +	msm_mux_pta2_1,
> +	msm_mux_pta2_2,
> +	msm_mux_pwm0,
> +	msm_mux_pwm1,
> +	msm_mux_pwm2,
> +	msm_mux_pwm3,
> +	msm_mux_qdss_cti_trig_in_a0,
> +	msm_mux_qdss_cti_trig_in_a1,
> +	msm_mux_qdss_cti_trig_in_b0,
> +	msm_mux_qdss_cti_trig_in_b1,
> +	msm_mux_qdss_cti_trig_out_a0,
> +	msm_mux_qdss_cti_trig_out_a1,
> +	msm_mux_qdss_cti_trig_out_b0,
> +	msm_mux_qdss_cti_trig_out_b1,
> +	msm_mux_qdss_traceclk_a,
> +	msm_mux_qdss_traceclk_b,
> +	msm_mux_qdss_tracectl_a,
> +	msm_mux_qdss_tracectl_b,
> +	msm_mux_qdss_tracedata_a,
> +	msm_mux_qdss_tracedata_b,
> +	msm_mux_qpic,
> +	msm_mux_rx0,
> +	msm_mux_rx1,
> +	msm_mux_rx2,
> +	msm_mux_sd_card,
> +	msm_mux_sd_write,
> +	msm_mux_tsens_max,
> +	msm_mux_wci2a,
> +	msm_mux_wci2b,
> +	msm_mux_wci2c,
> +	msm_mux_wci2d,
> +	msm_mux_NA,
> +};
> +
> +static const char * const qpic_groups[] = {
> +	"gpio0",	/* LCD_TE */
> +	"gpio1",	/* BUSY_N */
> +	"gpio2",	/* LCD_RS_N */
> +	"gpio3",	/* WE_N */
> +	"gpio4",	/* OE_N */
> +	"gpio5",	/* DATA[0] */
> +	"gpio6",	/* DATA[1] */
> +	"gpio7",	/* DATA[2] */
> +	"gpio8",	/* DATA[3] */
> +	"gpio9",	/* CS_CSR_LCD */
> +	"gpio10",	/* CLE */
> +	"gpio11",	/* NAND_CS_N */
> +	"gpio12",	/* DATA[4] */
> +	"gpio13",	/* DATA[5] */
> +	"gpio14",	/* DATA[6] */
> +	"gpio15",	/* DATA[7] */
> +	"gpio16",	/* DATA[8] */
> +	"gpio17",	/* ALE */
> +};
> +
> +static const char * const blsp5_i2c_groups[] = {
> +	"gpio0", "gpio2",
> +};
> +
> +static const char * const blsp5_spi_groups[] = {
> +	"gpio0", "gpio2", "gpio9", "gpio16",
> +};
> +
> +static const char * const wci2a_groups[] = {
> +	"gpio0", "gpio2",
> +};
> +
> +static const char * const blsp3_spi3_groups[] = {
> +	"gpio0", "gpio2", "gpio9",
> +};
> +
> +static const char * const burn0_groups[] = {
> +	"gpio0",
> +};
> +
> +static const char * const pcm_zsi0_groups[] = {
> +	"gpio1",
> +};
> +
> +static const char * const blsp5_uart_groups[] = {
> +	"gpio0", "gpio2", "gpio9", "gpio16",
> +};
> +
> +static const char * const mac1_sa2_groups[] = {
> +	"gpio1", "gpio11",
> +};
> +
> +static const char * const blsp3_spi0_groups[] = {
> +	"gpio1", "gpio3", "gpio4",
> +};
> +
> +static const char * const burn1_groups[] = {
> +	"gpio1",
> +};
> +
> +static const char * const mac0_sa1_groups[] = {
> +	"gpio3", "gpio4",
> +};
> +
> +static const char * const qdss_cti_trig_out_b0_groups[] = {
> +	"gpio3",
> +};
> +
> +static const char * const qdss_cti_trig_in_b0_groups[] = {
> +	"gpio4",
> +};
> +
> +static const char * const blsp4_uart0_groups[] = {
> +	"gpio5", "gpio6", "gpio7", "gpio8",
> +};
> +
> +static const char * const blsp4_i2c0_groups[] = {
> +	"gpio5", "gpio6",
> +};
> +
> +static const char * const blsp4_spi0_groups[] = {
> +	"gpio5", "gpio6", "gpio7", "gpio8",
> +};
> +
> +static const char * const mac2_sa1_groups[] = {
> +	"gpio5", "gpio6",
> +};
> +
> +static const char * const qdss_cti_trig_out_b1_groups[] = {
> +	"gpio5",
> +};
> +
> +static const char * const qdss_cti_trig_in_b1_groups[] = {
> +	"gpio6",
> +};
> +
> +static const char * const cxc0_groups[] = {
> +	"gpio9", "gpio16",
> +};
> +
> +static const char * const mac1_sa3_groups[] = {
> +	"gpio9", "gpio16",
> +};
> +
> +static const char * const qdss_cti_trig_in_a1_groups[] = {
> +	"gpio9",
> +};
> +
> +static const char * const qdss_cti_trig_out_a1_groups[] = {
> +	"gpio10",
> +};
> +
> +static const char * const wci2c_groups[] = {
> +	"gpio11", "gpio17",
> +};
> +
> +static const char * const qdss_cti_trig_in_a0_groups[] = {
> +	"gpio11",
> +};
> +
> +static const char * const qdss_cti_trig_out_a0_groups[] = {
> +	"gpio12",
> +};
> +
> +static const char * const qdss_traceclk_b_groups[] = {
> +	"gpio14",
> +};
> +
> +static const char * const qdss_tracectl_b_groups[] = {
> +	"gpio15",
> +};
> +
> +static const char * const pcm_zsi1_groups[] = {
> +	"gpio16",
> +};
> +
> +static const char * const qdss_tracedata_b_groups[] = {
> +	"gpio16", "gpio17", "gpio18", "gpio19", "gpio20", "gpio21", "gpio22",
> +	"gpio23", "gpio24", "gpio25", "gpio26", "gpio27", "gpio28", "gpio29",
> +	"gpio30", "gpio31",
> +};
> +
> +static const char * const led0_groups[] = {
> +	"gpio18",
> +};
> +
> +static const char * const pwm0_groups[] = {
> +	"gpio18", "gpio21", "gpio25", "gpio29", "gpio63",
> +};
> +
> +static const char * const led1_groups[] = {
> +	"gpio19",
> +};
> +
> +static const char * const pwm1_groups[] = {
> +	"gpio19", "gpio22", "gpio26", "gpio30", "gpio64",
> +};
> +
> +static const char * const led2_groups[] = {
> +	"gpio20",
> +};
> +
> +static const char * const pwm2_groups[] = {
> +	"gpio20", "gpio23", "gpio27", "gpio31", "gpio66",
> +};
> +
> +static const char * const blsp4_uart1_groups[] = {
> +	"gpio21", "gpio22", "gpio23", "gpio24",
> +};
> +
> +static const char * const blsp4_i2c1_groups[] = {
> +	"gpio21", "gpio22",
> +};
> +
> +static const char * const blsp4_spi1_groups[] = {
> +	"gpio21", "gpio22", "gpio23", "gpio24",
> +};
> +
> +static const char * const wci2d_groups[] = {
> +	"gpio21", "gpio22",
> +};
> +
> +static const char * const mac1_sa1_groups[] = {
> +	"gpio21", "gpio22",
> +};
> +
> +static const char * const blsp3_spi2_groups[] = {
> +	"gpio21", "gpio22", "gpio23",
> +};
> +
> +static const char * const pwm3_groups[] = {
> +	"gpio24", "gpio28", "gpio32", "gpio67",
> +};
> +
> +static const char * const audio_txmclk_groups[] = {
> +	"gpio25",
> +};
> +
> +static const char * const audio_txbclk_groups[] = {
> +	"gpio26",
> +};
> +
> +static const char * const audio_txfsync_groups[] = {
> +	"gpio27",
> +};
> +
> +static const char * const audio_txd_groups[] = {
> +	"gpio28",
> +};
> +
> +static const char * const audio_rxmclk_groups[] = {
> +	"gpio29",
> +};
> +
> +static const char * const atest_char0_groups[] = {
> +	"gpio29",
> +};
> +
> +static const char * const audio_rxbclk_groups[] = {
> +	"gpio30",
> +};
> +
> +static const char * const atest_char1_groups[] = {
> +	"gpio30",
> +};
> +
> +static const char * const audio_rxfsync_groups[] = {
> +	"gpio31",
> +};
> +
> +static const char * const atest_char2_groups[] = {
> +	"gpio31",
> +};
> +
> +static const char * const audio_rxd_groups[] = {
> +	"gpio32",
> +};
> +
> +static const char * const atest_char3_groups[] = {
> +	"gpio32",
> +};
> +
> +static const char * const pcm_drx_groups[] = {
> +	"gpio33",
> +};
> +
> +static const char * const mac1_sa0_groups[] = {
> +	"gpio33", "gpio34",
> +};
> +
> +static const char * const mac0_sa0_groups[] = {
> +	"gpio33", "gpio34",
> +};
> +
> +static const char * const pcm_dtx_groups[] = {
> +	"gpio34",
> +};
> +
> +static const char * const pcm_fsync_groups[] = {
> +	"gpio35",
> +};
> +
> +static const char * const mac2_sa0_groups[] = {
> +	"gpio35", "gpio36",
> +};
> +
> +static const char * const qdss_traceclk_a_groups[] = {
> +	"gpio35",
> +};
> +
> +static const char * const pcm_pclk_groups[] = {
> +	"gpio36",
> +};
> +
> +static const char * const qdss_tracectl_a_groups[] = {
> +	"gpio36",
> +};
> +
> +static const char * const atest_char_groups[] = {
> +	"gpio37",
> +};
> +
> +static const char * const qdss_tracedata_a_groups[] = {
> +	"gpio37", "gpio38", "gpio39", "gpio40", "gpio41", "gpio42", "gpio43",
> +	"gpio44", "gpio45", "gpio46", "gpio47", "gpio48", "gpio49", "gpio50",
> +	"gpio51", "gpio52",
> +};
> +
> +static const char * const blsp0_uart_groups[] = {
> +	"gpio38", "gpio39", "gpio40", "gpio41",
> +};
> +
> +static const char * const blsp0_i2c_groups[] = {
> +	"gpio38", "gpio39",
> +};
> +
> +static const char * const blsp0_spi_groups[] = {
> +	"gpio38", "gpio39", "gpio40", "gpio41",
> +};
> +
> +static const char * const blsp1_uart_groups[] = {
> +	"gpio42", "gpio43", "gpio44", "gpio45",
> +};
> +
> +static const char * const blsp1_i2c_groups[] = {
> +	"gpio42", "gpio43",
> +};
> +
> +static const char * const blsp1_spi_groups[] = {
> +	"gpio42", "gpio43", "gpio44", "gpio45",
> +};
> +
> +static const char * const blsp2_uart_groups[] = {
> +	"gpio46", "gpio47", "gpio48", "gpio49",
> +};
> +
> +static const char * const blsp2_i2c_groups[] = {
> +	"gpio46", "gpio47",
> +};
> +
> +static const char * const blsp2_spi_groups[] = {
> +	"gpio46", "gpio47", "gpio48", "gpio49",
> +};
> +
> +static const char * const blsp3_uart_groups[] = {
> +	"gpio50", "gpio51", "gpio52", "gpio53",
> +};
> +
> +static const char * const blsp3_i2c_groups[] = {
> +	"gpio50", "gpio51",
> +};
> +
> +static const char * const blsp3_spi_groups[] = {
> +	"gpio50", "gpio51", "gpio52", "gpio53",
> +};
> +
> +static const char * const pta2_0_groups[] = {
> +	"gpio54",
> +};
> +
> +static const char * const wci2b_groups[] = {
> +	"gpio54", "gpio56",
> +};
> +
> +static const char * const cxc1_groups[] = {
> +	"gpio54", "gpio56",
> +};
> +
> +static const char * const blsp3_spi1_groups[] = {
> +	"gpio54", "gpio55", "gpio56",
> +};
> +
> +static const char * const pta2_1_groups[] = {
> +	"gpio55",
> +};
> +
> +static const char * const pta2_2_groups[] = {
> +	"gpio56",
> +};
> +
> +static const char * const pcie0_clk_groups[] = {
> +	"gpio57",
> +};
> +
> +static const char * const dbg_out_groups[] = {
> +	"gpio57",
> +};
> +
> +static const char * const cri_trng0_groups[] = {
> +	"gpio57",
> +};
> +
> +static const char * const pcie0_rst_groups[] = {
> +	"gpio58",
> +};
> +
> +static const char * const cri_trng1_groups[] = {
> +	"gpio58",
> +};
> +
> +static const char * const pcie0_wake_groups[] = {
> +	"gpio59",
> +};
> +
> +static const char * const cri_trng_groups[] = {
> +	"gpio59",
> +};
> +
> +static const char * const pcie1_clk_groups[] = {
> +	"gpio60",
> +};
> +
> +static const char * const rx2_groups[] = {
> +	"gpio60",
> +};
> +
> +static const char * const ldo_update_groups[] = {
> +	"gpio60",
> +};
> +
> +static const char * const pcie1_rst_groups[] = {
> +	"gpio61",
> +};
> +
> +static const char * const ldo_en_groups[] = {
> +	"gpio61",
> +};
> +
> +static const char * const pcie1_wake_groups[] = {
> +	"gpio62",
> +};
> +
> +static const char * const gcc_plltest_groups[] = {
> +	"gpio62", "gpio63",
> +};
> +
> +static const char * const sd_card_groups[] = {
> +	"gpio63",
> +};
> +
> +static const char * const pta1_1_groups[] = {
> +	"gpio64",
> +};
> +
> +static const char * const rx1_groups[] = {
> +	"gpio64",
> +};
> +
> +static const char * const pta1_2_groups[] = {
> +	"gpio65",
> +};
> +
> +static const char * const gcc_tlmm_groups[] = {
> +	"gpio65",
> +};
> +
> +static const char * const pta1_0_groups[] = {
> +	"gpio66",
> +};
> +
> +static const char * const prng_rosc_groups[] = {
> +	"gpio66",
> +};
> +
> +static const char * const sd_write_groups[] = {
> +	"gpio67",
> +};
> +
> +static const char * const rx0_groups[] = {
> +	"gpio67",
> +};
> +
> +static const char * const tsens_max_groups[] = {
> +	"gpio67",
> +};
> +
> +static const char * const mdc_groups[] = {
> +	"gpio68",
> +};
> +
> +static const char * const mdio_groups[] = {
> +	"gpio69",
> +};
> +
> +static const char * const gpio_groups[] = {
> +	"gpio0", "gpio1", "gpio2", "gpio3", "gpio4", "gpio5", "gpio6", "gpio7",
> +	"gpio8", "gpio9", "gpio10", "gpio11", "gpio12", "gpio13", "gpio14",
> +	"gpio15", "gpio16", "gpio17", "gpio18", "gpio19", "gpio20", "gpio21",
> +	"gpio22", "gpio23", "gpio24", "gpio25", "gpio26", "gpio27", "gpio28",
> +	"gpio29", "gpio30", "gpio31", "gpio32", "gpio33", "gpio34", "gpio35",
> +	"gpio36", "gpio37", "gpio38", "gpio39", "gpio40", "gpio41", "gpio42",
> +	"gpio43", "gpio44", "gpio45", "gpio46", "gpio47", "gpio48", "gpio49",
> +	"gpio50", "gpio51", "gpio52", "gpio53", "gpio54", "gpio55", "gpio56",
> +	"gpio57", "gpio58", "gpio59", "gpio60", "gpio61", "gpio62", "gpio63",
> +	"gpio64", "gpio65", "gpio66", "gpio67", "gpio68", "gpio69",
> +};
> +
> +static const struct msm_function ipq8074_functions[] = {
> +	FUNCTION(atest_char),
> +	FUNCTION(atest_char0),
> +	FUNCTION(atest_char1),
> +	FUNCTION(atest_char2),
> +	FUNCTION(atest_char3),
> +	FUNCTION(audio_rxbclk),
> +	FUNCTION(audio_rxd),
> +	FUNCTION(audio_rxfsync),
> +	FUNCTION(audio_rxmclk),
> +	FUNCTION(audio_txbclk),
> +	FUNCTION(audio_txd),
> +	FUNCTION(audio_txfsync),
> +	FUNCTION(audio_txmclk),
> +	FUNCTION(blsp0_i2c),
> +	FUNCTION(blsp0_spi),
> +	FUNCTION(blsp0_uart),
> +	FUNCTION(blsp1_i2c),
> +	FUNCTION(blsp1_spi),
> +	FUNCTION(blsp1_uart),
> +	FUNCTION(blsp2_i2c),
> +	FUNCTION(blsp2_spi),
> +	FUNCTION(blsp2_uart),
> +	FUNCTION(blsp3_i2c),
> +	FUNCTION(blsp3_spi),
> +	FUNCTION(blsp3_spi0),
> +	FUNCTION(blsp3_spi1),
> +	FUNCTION(blsp3_spi2),
> +	FUNCTION(blsp3_spi3),
> +	FUNCTION(blsp3_uart),
> +	FUNCTION(blsp4_i2c0),
> +	FUNCTION(blsp4_i2c1),
> +	FUNCTION(blsp4_spi0),
> +	FUNCTION(blsp4_spi1),
> +	FUNCTION(blsp4_uart0),
> +	FUNCTION(blsp4_uart1),
> +	FUNCTION(blsp5_i2c),
> +	FUNCTION(blsp5_spi),
> +	FUNCTION(blsp5_uart),
> +	FUNCTION(burn0),
> +	FUNCTION(burn1),
> +	FUNCTION(cri_trng),
> +	FUNCTION(cri_trng0),
> +	FUNCTION(cri_trng1),
> +	FUNCTION(cxc0),
> +	FUNCTION(cxc1),
> +	FUNCTION(dbg_out),
> +	FUNCTION(gcc_plltest),
> +	FUNCTION(gcc_tlmm),
> +	FUNCTION(gpio),
> +	FUNCTION(ldo_en),
> +	FUNCTION(ldo_update),
> +	FUNCTION(led0),
> +	FUNCTION(led1),
> +	FUNCTION(led2),
> +	FUNCTION(mac0_sa0),
> +	FUNCTION(mac0_sa1),
> +	FUNCTION(mac1_sa0),
> +	FUNCTION(mac1_sa1),
> +	FUNCTION(mac1_sa2),
> +	FUNCTION(mac1_sa3),
> +	FUNCTION(mac2_sa0),
> +	FUNCTION(mac2_sa1),
> +	FUNCTION(mdc),
> +	FUNCTION(mdio),
> +	FUNCTION(pcie0_clk),
> +	FUNCTION(pcie0_rst),
> +	FUNCTION(pcie0_wake),
> +	FUNCTION(pcie1_clk),
> +	FUNCTION(pcie1_rst),
> +	FUNCTION(pcie1_wake),
> +	FUNCTION(pcm_drx),
> +	FUNCTION(pcm_dtx),
> +	FUNCTION(pcm_fsync),
> +	FUNCTION(pcm_pclk),
> +	FUNCTION(pcm_zsi0),
> +	FUNCTION(pcm_zsi1),
> +	FUNCTION(prng_rosc),
> +	FUNCTION(pta1_0),
> +	FUNCTION(pta1_1),
> +	FUNCTION(pta1_2),
> +	FUNCTION(pta2_0),
> +	FUNCTION(pta2_1),
> +	FUNCTION(pta2_2),
> +	FUNCTION(pwm0),
> +	FUNCTION(pwm1),
> +	FUNCTION(pwm2),
> +	FUNCTION(pwm3),
> +	FUNCTION(qdss_cti_trig_in_a0),
> +	FUNCTION(qdss_cti_trig_in_a1),
> +	FUNCTION(qdss_cti_trig_in_b0),
> +	FUNCTION(qdss_cti_trig_in_b1),
> +	FUNCTION(qdss_cti_trig_out_a0),
> +	FUNCTION(qdss_cti_trig_out_a1),
> +	FUNCTION(qdss_cti_trig_out_b0),
> +	FUNCTION(qdss_cti_trig_out_b1),
> +	FUNCTION(qdss_traceclk_a),
> +	FUNCTION(qdss_traceclk_b),
> +	FUNCTION(qdss_tracectl_a),
> +	FUNCTION(qdss_tracectl_b),
> +	FUNCTION(qdss_tracedata_a),
> +	FUNCTION(qdss_tracedata_b),
> +	FUNCTION(qpic),
> +	FUNCTION(rx0),
> +	FUNCTION(rx1),
> +	FUNCTION(rx2),
> +	FUNCTION(sd_card),
> +	FUNCTION(sd_write),
> +	FUNCTION(tsens_max),
> +	FUNCTION(wci2a),
> +	FUNCTION(wci2b),
> +	FUNCTION(wci2c),
> +	FUNCTION(wci2d),
> +};
> +
> +static const struct msm_pingroup ipq8074_groups[] = {
> +	PINGROUP(0, qpic, blsp5_uart, blsp5_i2c, blsp5_spi, wci2a,
> +		 blsp3_spi3, NA, burn0, NA),
> +	PINGROUP(1, qpic, pcm_zsi0, mac1_sa2, blsp3_spi0, NA, burn1, NA, NA,
> +		 NA),
> +	PINGROUP(2, qpic, blsp5_uart, blsp5_i2c, blsp5_spi, wci2a,
> +		 blsp3_spi3, NA, NA, NA),
> +	PINGROUP(3, qpic, mac0_sa1, blsp3_spi0, qdss_cti_trig_out_b0, NA, NA,
> +		 NA, NA, NA),
> +	PINGROUP(4, qpic, mac0_sa1, blsp3_spi0, qdss_cti_trig_in_b0, NA, NA,
> +		 NA, NA, NA),
> +	PINGROUP(5, qpic, blsp4_uart0, blsp4_i2c0, blsp4_spi0, mac2_sa1,
> +		 qdss_cti_trig_out_b1, NA, NA, NA),
> +	PINGROUP(6, qpic, blsp4_uart0, blsp4_i2c0, blsp4_spi0, mac2_sa1,
> +		 qdss_cti_trig_in_b1, NA, NA, NA),
> +	PINGROUP(7, qpic, blsp4_uart0, blsp4_spi0, NA, NA, NA, NA, NA, NA),
> +	PINGROUP(8, qpic, blsp4_uart0, blsp4_spi0, NA, NA, NA, NA, NA, NA),
> +	PINGROUP(9, qpic, blsp5_uart, blsp5_spi, cxc0, mac1_sa3, blsp3_spi3,
> +		 qdss_cti_trig_in_a1, NA, NA),
> +	PINGROUP(10, qpic, qdss_cti_trig_out_a1, NA, NA, NA, NA, NA, NA,
> +		 NA),
> +	PINGROUP(11, qpic, wci2c, mac1_sa2, qdss_cti_trig_in_a0, NA, NA, NA,
> +		 NA, NA),
> +	PINGROUP(12, qpic, qdss_cti_trig_out_a0, NA, NA, NA, NA, NA, NA,
> +		 NA),
> +	PINGROUP(13, qpic, NA, NA, NA, NA, NA, NA, NA, NA),
> +	PINGROUP(14, qpic, qdss_traceclk_b, NA, NA, NA, NA, NA, NA, NA),
> +	PINGROUP(15, qpic, qdss_tracectl_b, NA, NA, NA, NA, NA, NA, NA),
> +	PINGROUP(16, qpic, blsp5_uart, pcm_zsi1, blsp5_spi, cxc0, mac1_sa3,
> +		 qdss_tracedata_b, NA, NA),
> +	PINGROUP(17, qpic, wci2c, qdss_tracedata_b, NA, NA, NA, NA, NA, NA),
> +	PINGROUP(18, led0, pwm0, qdss_tracedata_b, NA, NA, NA, NA, NA, NA),
> +	PINGROUP(19, led1, pwm1, NA, qdss_tracedata_b, NA, NA, NA, NA, NA),
> +	PINGROUP(20, led2, pwm2, NA, qdss_tracedata_b, NA, NA, NA, NA, NA),
> +	PINGROUP(21, pwm0, blsp4_uart1, blsp4_i2c1, blsp4_spi1, wci2d, mac1_sa1,
> +		 blsp3_spi2, NA, qdss_tracedata_b),
> +	PINGROUP(22, pwm1, blsp4_uart1, blsp4_i2c1, blsp4_spi1, wci2d, mac1_sa1,
> +		 blsp3_spi2, NA, qdss_tracedata_b),
> +	PINGROUP(23, pwm2, blsp4_uart1, blsp4_spi1, blsp3_spi2, NA,
> +		 qdss_tracedata_b, NA, NA, NA),
> +	PINGROUP(24, pwm3, blsp4_uart1, blsp4_spi1, NA, qdss_tracedata_b, NA,
> +		 NA, NA, NA),
> +	PINGROUP(25, audio_txmclk, pwm0, NA, qdss_tracedata_b, NA, NA, NA, NA,
> +		 NA),
> +	PINGROUP(26, audio_txbclk, pwm1, NA, qdss_tracedata_b, NA, NA, NA, NA,
> +		 NA),
> +	PINGROUP(27, audio_txfsync, pwm2, NA, qdss_tracedata_b, NA, NA, NA,
> +		 NA, NA),
> +	PINGROUP(28, audio_txd, pwm3, NA, qdss_tracedata_b, NA, NA, NA, NA,
> +		 NA),
> +	PINGROUP(29, audio_rxmclk, pwm0, atest_char0, NA, qdss_tracedata_b,
> +		 NA, NA, NA, NA),
> +	PINGROUP(30, audio_rxbclk, pwm1, atest_char1, NA, qdss_tracedata_b,
> +		 NA, NA, NA, NA),
> +	PINGROUP(31, audio_rxfsync, pwm2, atest_char2, NA, qdss_tracedata_b,
> +		 NA, NA, NA, NA),
> +	PINGROUP(32, audio_rxd, pwm3, atest_char3, NA, NA, NA, NA, NA, NA),
> +	PINGROUP(33, pcm_drx, mac1_sa0, mac0_sa0, NA, NA, NA, NA, NA, NA),
> +	PINGROUP(34, pcm_dtx, mac1_sa0, mac0_sa0, NA, NA, NA, NA, NA, NA),
> +	PINGROUP(35, pcm_fsync, mac2_sa0, qdss_traceclk_a, NA, NA, NA, NA, NA, NA),
> +	PINGROUP(36, pcm_pclk, mac2_sa0, NA, qdss_tracectl_a, NA, NA, NA, NA, NA),
> +	PINGROUP(37, atest_char, NA, qdss_tracedata_a, NA, NA, NA, NA, NA, NA),
> +	PINGROUP(38, blsp0_uart, blsp0_i2c, blsp0_spi, NA, qdss_tracedata_a,
> +		 NA, NA, NA, NA),
> +	PINGROUP(39, blsp0_uart, blsp0_i2c, blsp0_spi, NA, qdss_tracedata_a,
> +		 NA, NA, NA, NA),
> +	PINGROUP(40, blsp0_uart, blsp0_spi, NA, qdss_tracedata_a, NA, NA, NA,
> +		 NA, NA),
> +	PINGROUP(41, blsp0_uart, blsp0_spi, NA, qdss_tracedata_a, NA, NA, NA,
> +		 NA, NA),
> +	PINGROUP(42, blsp1_uart, blsp1_i2c, blsp1_spi, NA, qdss_tracedata_a,
> +		 NA, NA, NA, NA),
> +	PINGROUP(43, blsp1_uart, blsp1_i2c, blsp1_spi, NA, qdss_tracedata_a,
> +		 NA, NA, NA, NA),
> +	PINGROUP(44, blsp1_uart, blsp1_spi, NA, qdss_tracedata_a, NA, NA, NA,
> +		 NA, NA),
> +	PINGROUP(45, blsp1_uart, blsp1_spi, qdss_tracedata_a, NA, NA, NA, NA,
> +		 NA, NA),
> +	PINGROUP(46, blsp2_uart, blsp2_i2c, blsp2_spi, qdss_tracedata_a, NA,
> +		 NA, NA, NA, NA),
> +	PINGROUP(47, blsp2_uart, blsp2_i2c, blsp2_spi, NA, qdss_tracedata_a,
> +		 NA, NA, NA, NA),
> +	PINGROUP(48, blsp2_uart, blsp2_spi, NA, qdss_tracedata_a, NA, NA, NA,
> +		 NA, NA),
> +	PINGROUP(49, blsp2_uart, blsp2_spi, NA, qdss_tracedata_a, NA, NA, NA,
> +		 NA, NA),
> +	PINGROUP(50, blsp3_uart, blsp3_i2c, blsp3_spi, NA, qdss_tracedata_a,
> +		 NA, NA, NA, NA),
> +	PINGROUP(51, blsp3_uart, blsp3_i2c, blsp3_spi, NA, qdss_tracedata_a,
> +		 NA, NA, NA, NA),
> +	PINGROUP(52, blsp3_uart, blsp3_spi, NA, qdss_tracedata_a, NA, NA, NA,
> +		 NA, NA),
> +	PINGROUP(53, blsp3_uart, blsp3_spi, NA, NA, NA, NA, NA, NA, NA),
> +	PINGROUP(54, pta2_0, wci2b, cxc1, blsp3_spi1, NA, NA, NA, NA, NA),
> +	PINGROUP(55, pta2_1, blsp3_spi1, NA, NA, NA, NA, NA, NA, NA),
> +	PINGROUP(56, pta2_2, wci2b, cxc1, blsp3_spi1, NA, NA, NA, NA, NA),
> +	PINGROUP(57, pcie0_clk, NA, dbg_out, cri_trng0, NA, NA, NA, NA, NA),
> +	PINGROUP(58, pcie0_rst, NA, cri_trng1, NA, NA, NA, NA, NA, NA),
> +	PINGROUP(59, pcie0_wake, NA, cri_trng, NA, NA, NA, NA, NA, NA),
> +	PINGROUP(60, pcie1_clk, rx2, ldo_update, NA, NA, NA, NA, NA, NA),
> +	PINGROUP(61, pcie1_rst, ldo_en, NA, NA, NA, NA, NA, NA, NA),
> +	PINGROUP(62, pcie1_wake, gcc_plltest, NA, NA, NA, NA, NA, NA, NA),
> +	PINGROUP(63, sd_card, pwm0, NA, gcc_plltest, NA, NA, NA, NA, NA),
> +	PINGROUP(64, pta1_1, pwm1, NA, rx1, NA, NA, NA, NA, NA),
> +	PINGROUP(65, pta1_2, NA, gcc_tlmm, NA, NA, NA, NA, NA, NA),
> +	PINGROUP(66, pta1_0, pwm2, prng_rosc, NA, NA, NA, NA, NA, NA),
> +	PINGROUP(67, sd_write, pwm3, rx0, tsens_max, NA, NA, NA, NA, NA),
> +	PINGROUP(68, mdc, NA, NA, NA, NA, NA, NA, NA, NA),
> +	PINGROUP(69, mdio, NA, NA, NA, NA, NA, NA, NA, NA),
> +};
> +
> +static const struct msm_pinctrl_soc_data ipq8074_pinctrl = {
> +	.pins = ipq8074_pins,
> +	.npins = ARRAY_SIZE(ipq8074_pins),
> +	.functions = ipq8074_functions,
> +	.nfunctions = ARRAY_SIZE(ipq8074_functions),
> +	.groups = ipq8074_groups,
> +	.ngroups = ARRAY_SIZE(ipq8074_groups),
> +	.ngpios = 70,
> +};
> +
> +static int ipq8074_pinctrl_probe(struct platform_device *pdev)
> +{
> +	return msm_pinctrl_probe(pdev, &ipq8074_pinctrl);
> +}
> +
> +static const struct of_device_id ipq8074_pinctrl_of_match[] = {
> +	{ .compatible = "qcom,ipq8074-pinctrl", },
> +	{ },
> +};
> +
> +static struct platform_driver ipq8074_pinctrl_driver = {
> +	.driver = {
> +		.name = "ipq8074-pinctrl",
> +		.of_match_table = ipq8074_pinctrl_of_match,
> +	},
> +	.probe = ipq8074_pinctrl_probe,
> +	.remove = msm_pinctrl_remove,
> +};
> +
> +static int __init ipq8074_pinctrl_init(void)
> +{
> +	return platform_driver_register(&ipq8074_pinctrl_driver);
> +}
> +arch_initcall(ipq8074_pinctrl_init);
> +
> +static void __exit ipq8074_pinctrl_exit(void)
> +{
> +	platform_driver_unregister(&ipq8074_pinctrl_driver);
> +}
> +module_exit(ipq8074_pinctrl_exit);
> +
> +MODULE_DESCRIPTION("Qualcomm ipq8074 pinctrl driver");
> +MODULE_LICENSE("GPL v2");
> +MODULE_DEVICE_TABLE(of, ipq8074_pinctrl_of_match);
> 

Does this look fine, or do you have anymore comments?

Thanks
Varada

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum, a Linux Foundation Collaborative Project

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ