linux-kernel - Re: [PATCH v3 10/18] xen/pvcalls: implement listen command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c1720bd4-dc92-2d14-c562-199f1d44d03e@suse.com>
Date:   Tue, 13 Jun 2017 09:00:57 +0200
From:   Juergen Gross <jgross@...e.com>
To:     Stefano Stabellini <sstabellini@...nel.org>,
        xen-devel@...ts.xen.org
Cc:     linux-kernel@...r.kernel.org, boris.ostrovsky@...cle.com,
        Stefano Stabellini <stefano@...reto.com>
Subject: Re: [PATCH v3 10/18] xen/pvcalls: implement listen command

On 02/06/17 21:31, Stefano Stabellini wrote:
> Call inet_listen to implement the listen command.
> 
> Signed-off-by: Stefano Stabellini <stefano@...reto.com>
> CC: boris.ostrovsky@...cle.com
> CC: jgross@...e.com
> ---
>  drivers/xen/pvcalls-back.c | 21 ++++++++++++++++++++-
>  1 file changed, 20 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
> index 4a0cfa3..a75586e 100644
> --- a/drivers/xen/pvcalls-back.c
> +++ b/drivers/xen/pvcalls-back.c
> @@ -355,7 +355,26 @@ static int pvcalls_back_bind(struct xenbus_device *dev,
>  static int pvcalls_back_listen(struct xenbus_device *dev,
>  			       struct xen_pvcalls_request *req)
>  {
> -	return 0;
> +	struct pvcalls_fedata *priv;
> +	int ret = -EINVAL;
> +	struct sockpass_mapping *map;
> +	struct xen_pvcalls_response *rsp;
> +
> +	priv = dev_get_drvdata(&dev->dev);
> +
> +	map = radix_tree_lookup(&priv->socketpass_mappings, req->u.listen.id);
> +	if (map == NULL)
> +		goto out;
> +
> +	ret = inet_listen(map->sock, req->u.listen.backlog);
> +
> +out:
> +	rsp = RING_GET_RESPONSE(&priv->ring, priv->ring.rsp_prod_pvt++);
> +	rsp->req_id = req->req_id;
> +	rsp->cmd = req->cmd;
> +	rsp->u.listen.id = req->u.listen.id;
> +	rsp->ret = ret;
> +	return ret;

return 0?


Juergen

>  }
>  
>  static int pvcalls_back_accept(struct xenbus_device *dev,
>