linux-kernel - Re: [PATCH] mwifiex: fixes the trivial print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2eb9e680-64bc-a74d-f224-b6e13dd3b45b@rock-chips.com>
Date:   Tue, 13 Jun 2017 15:42:15 +0800
From:   Caesar Wang <wxt@...k-chips.com>
To:     Kalle Valo <kvalo@...eaurora.org>
Cc:     amitkarwar@...il.com, huxm@...vell.com, nishants@...vell.com,
        gbhat@...vell.com, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        briannorris@...omium.org, jeffy.chen@...k-chips.com
Subject: Re: [PATCH] mwifiex: fixes the trivial print

在 2017年06月13日 15:04, Kalle Valo 写道:
> Caesar Wang <wxt@...k-chips.com> writes:
>
>> Kalle,
>>
>> 在 2017年06月13日 14:28, Kalle Valo 写道:
>>> Caesar Wang <wxt@...k-chips.com> writes:
>>>
>>>> We have always met the unused log be printed as following.
>>>>
>>>> ...
>>>> [23193.523182] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp:
>>>> cannot find cfp by band 2    & channel=13 freq=0
>>>> [23378.633684] mwifiex_pcie 0000:01:00.0: mwifiex_get_cfp:
>>>> cannot find cfp by band 2    & channel=13 freq=0
>>>>
>>>> Maybe that's related to wifi regdom, since wifi default area
>>>> was US and didn't support 12~14 channels.
>>>>
>>>> As Frequencies:
>>>> * 2412 MHz [1] (30.0 dBm)
>>>> * 2417 MHz [2] (30.0 dBm)
>>>> * 2422 MHz [3] (30.0 dBm)
>>>> * 2427 MHz [4] (30.0 dBm)
>>>> * 2432 MHz [5] (30.0 dBm)
>>>> * 2437 MHz [6] (30.0 dBm)
>>>> * 2442 MHz [7] (30.0 dBm)
>>>> * 2447 MHz [8] (30.0 dBm)
>>>> * 2452 MHz [9] (30.0 dBm)
>>>> * 2457 MHz [10] (30.0 dBm)
>>>> * 2462 MHz [11] (30.0 dBm)
>>>> * 2467 MHz [12] (disabled)
>>>> * 2472 MHz [13] (disabled)
>>>> * 2484 MHz [14] (disabled)
>>>>
>>>> Signed-off-by: Caesar Wang <wxt@...k-chips.com>
>>>> ---
>>>>
>>>>    drivers/net/wireless/marvell/mwifiex/cfp.c | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/net/wireless/marvell/mwifiex/cfp.c b/drivers/net/wireless/marvell/mwifiex/cfp.c
>>>> index 1ff2205..6e29943 100644
>>>> --- a/drivers/net/wireless/marvell/mwifiex/cfp.c
>>>> +++ b/drivers/net/wireless/marvell/mwifiex/cfp.c
>>>> @@ -350,7 +350,7 @@ mwifiex_get_cfp(struct mwifiex_private *priv, u8 band, u16 channel, u32 freq)
>>>>    		}
>>>>    	}
>>>>    	if (i == sband->n_channels) {
>>>> -		mwifiex_dbg(priv->adapter, ERROR,
>>>> +		mwifiex_dbg(priv->adapter, WARN,
>>>>    			    "%s: cannot find cfp by band %d\t"
>>>>    			    "& channel=%d freq=%d\n",
>>>>    			    __func__, band, channel, freq);
>>> I don't see how this fixes anything, care to explain? And the title is
>>> quite vague.
>> Sorry for the description maybe unclear.
>> I'm assuming the print log is expected for marvel wifi driver. Do we
>> should use 'WARN' to instead of the 'ERROR' here.
> But does that make any functional difference, isn't the warning still
> printed?
>

At least, that shouldn't be printed log by default.  :)

if I read the code is correct. That only the MSG/FATAL/ERROR will output 
by default.

/**
  *enum mwifiex_debug_level  -  marvell wifi debug level
  */
enum MWIFIEX_DEBUG_LEVEL {
     MWIFIEX_DBG_MSG        = 0x00000001,
     MWIFIEX_DBG_FATAL    = 0x00000002,
     MWIFIEX_DBG_ERROR    = 0x00000004,
     MWIFIEX_DBG_DATA    = 0x00000008,
     MWIFIEX_DBG_CMD        = 0x00000010,
     MWIFIEX_DBG_EVENT    = 0x00000020,
     MWIFIEX_DBG_INTR    = 0x00000040,
     MWIFIEX_DBG_IOCTL    = 0x00000080,

     MWIFIEX_DBG_MPA_D    = 0x00008000,
     MWIFIEX_DBG_DAT_D    = 0x00010000,
     MWIFIEX_DBG_CMD_D    = 0x00020000,
     MWIFIEX_DBG_EVT_D    = 0x00040000,
     MWIFIEX_DBG_FW_D    = 0x00080000,
     MWIFIEX_DBG_IF_D    = 0x00100000,

     MWIFIEX_DBG_ENTRY    = 0x10000000,
     MWIFIEX_DBG_WARN    = 0x20000000,
     MWIFIEX_DBG_INFO    = 0x40000000,
     MWIFIEX_DBG_DUMP    = 0x80000000,

     MWIFIEX_DBG_ANY        = 0xffffffff
};

#define MWIFIEX_DEFAULT_DEBUG_MASK    (MWIFIEX_DBG_MSG | \
                     MWIFIEX_DBG_FATAL | \
                     MWIFIEX_DBG_ERROR)