linux-kernel - Re: [PATCH v2] Kbuild: tiny correction on `make help`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <593FB5F2.4040206@cn.fujitsu.com>
Date:   Tue, 13 Jun 2017 17:52:50 +0800
From:   Cao jin <caoj.fnst@...fujitsu.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
CC:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Michal Marek <mmarek@...e.com>
Subject: Re: [PATCH v2] Kbuild: tiny correction on `make help`

Yamada-san,

  I have a question on the current top level Makefile. There are
following lines, I have trouble to understand "firstword x$(MAKEFLAGS)"
in 2nd line, why there is a 'x' there?


  ifneq ($(filter 4.%,$(MAKE_VERSION)),)  # make-4
  ifneq ($(filter %s ,$(firstword x$(MAKEFLAGS))),)
    quiet=silent_
    tools_silent=s
  endif
  else                                    # make-3.8x
  ifneq ($(filter s% -s%,$(MAKEFLAGS)),)
    quiet=silent_
    tools_silent=-s
  endif
  endif

  I already read & understand your patch[*] and know these lines will be
modified, but I have spent quite a few days on understanding it, so I
still want to know the purpose of 'x'.

[*]https://lkml.org/lkml/2017/5/19/371

-- 
Sincerely,
Cao jin

On 06/06/2017 11:01 PM, Masahiro Yamada wrote:
> 2017-06-06 18:07 GMT+09:00 Cao jin <caoj.fnst@...fujitsu.com>:
>> The help info of `make C=1` is little confusing, make it clear.
>>
>> Signed-off-by: Cao jin <caoj.fnst@...fujitsu.com>
> 
> 
> Applied to linux-kbuild/fixes.  Thanks!
>