linux-kernel - Re: [PATCH][crypto-next] crypto: cavium: fix spelling mistake "Revsion" -> "Revision"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Jun 2017 03:36:12 -0700
From:   Joe Perches <joe@...ches.com>
To:     Colin King <colin.king@...onical.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S . Miller" <davem@...emloft.net>,
        Srikanth Jampala <Jampala.Srikanth@...ium.com>,
        linux-crypto@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][crypto-next] crypto: cavium: fix spelling mistake
 "Revsion" -> "Revision"

On Tue, 2017-06-13 at 09:52 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Trivial fix to spelling mistake in seq_printf message

Hey Colin.

Fixing spelling typos is a good thing, but is it a
good thing to change possibly API dependent output
in seq_ calls?

> diff --git a/drivers/crypto/cavium/nitrox/nitrox_main.c b/drivers/crypto/cavium/nitrox/nitrox_main.c
[]
> @@ -399,7 +399,7 @@ static int nitrox_show(struct seq_file *s, void *v)
>  	struct nitrox_device *ndev = s->private;
>  
>  	seq_printf(s, "NITROX-5 [idx: %d]\n", ndev->idx);
> -	seq_printf(s, "  Revsion ID: 0x%0x\n", ndev->hw.revision_id);
> +	seq_printf(s, "  Revision ID: 0x%0x\n", ndev->hw.revision_id);
>  	seq_printf(s, "  Cores [AE: %u  SE: %u]\n",
>  		   ndev->hw.ae_cores, ndev->hw.se_cores);
>  	seq_printf(s, "  Number of Queues: %u\n", ndev->nr_queues);