linux-kernel - Re: [PATCH 1/7] staging: rtl8723bs: wifi_regd.c: put spaces around binary operators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170613131149.GA23757@kroah.com>
Date:   Tue, 13 Jun 2017 15:11:49 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Fabian Wolff <fabian.wolff@....de>
Cc:     horvatmate@...il.com, hdegoede@...hat.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        linux-kernel@...cs.fau.de
Subject: Re: [PATCH 1/7] staging: rtl8723bs: wifi_regd.c: put spaces around
 binary operators

On Tue, Jun 13, 2017 at 02:58:43PM +0200, Greg KH wrote:
> On Mon, Jun 12, 2017 at 12:46:10PM +0200, Fabian Wolff wrote:
> > This patch adds spaces around the binary operators '-' and '+', which
> > is the preferred style, and reformats a pointer argument declaration
> > to fix a false positive "spaces preferred around that '*'" message
> > reported by checkpatch.pl.
> > 
> > Signed-off-by: Fabian Wolff <fabian.wolff@....de>
> > Signed-off-by: Mate Horvath <horvatmate@...il.com>
> > ---
> >  drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/staging/rtl8723bs/os_dep/wifi_regd.c b/drivers/staging/rtl8723bs/os_dep/wifi_regd.c
> > index 9c61125..803eab0 100644
> > --- a/drivers/staging/rtl8723bs/os_dep/wifi_regd.c
> > +++ b/drivers/staging/rtl8723bs/os_dep/wifi_regd.c
> > @@ -20,7 +20,7 @@
> >  
> >  /* 2G chan 01 - chan 11 */
> >  #define RTW_2GHZ_CH01_11	\
> > -	REG_RULE(2412-10, 2462+10, 40, 0, 20, 0)
> > +	REG_RULE(2412 - 10, 2462 + 10, 40, 0, 20, 0)
> >  
> >  /*
> >   *We enable active scan on these a case
> > @@ -29,12 +29,12 @@
> >  
> >  /* 2G chan 12 - chan 13, PASSIV SCAN */
> >  #define RTW_2GHZ_CH12_13	\
> > -	REG_RULE(2467-10, 2472+10, 40, 0, 20,	\
> > +	REG_RULE(2467 - 10, 2472 + 10, 40, 0, 20,	\
> >  	NL80211_RRF_PASSIVE_SCAN)
> >  
> >  /* 2G chan 14, PASSIVS SCAN, NO OFDM (B only) */
> >  #define RTW_2GHZ_CH14	\
> > -	REG_RULE(2484-10, 2484+10, 40, 0, 20,	\
> > +	REG_RULE(2484 - 10, 2484 + 10, 40, 0, 20,	\
> >  	NL80211_RRF_PASSIVE_SCAN | NL80211_RRF_NO_OFDM)
> >  
> >  static const struct ieee80211_regdomain rtw_regdom_rd = {
> > @@ -116,8 +116,8 @@ static int _rtw_reg_notifier_apply(struct wiphy *wiphy,
> >  }
> >  
> >  static const struct ieee80211_regdomain *_rtw_regdomain_select(struct
> > -							       rtw_regulatory
> > -							       *reg)
> > +							       rtw_regulatory *
> > +							       reg)
> 
> Why make this last change?  It's not an arithmatic one :(

And can you refresh this series and resend the remaining ones?  They all
didn't apply :(