linux-kernel - Re: [PATCH] xen/mce: don't issue error message for failed /dev/mcelog registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170613131723.zjw2y5uewoayxfgw@pd.tnic>
Date:   Tue, 13 Jun 2017 15:17:23 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Juergen Gross <jgross@...e.com>
Cc:     linux-kernel@...r.kernel.org, xen-devel@...ts.xenproject.org,
        x86@...nel.org, boris.ostrovsky@...cle.com, hpa@...or.com,
        tglx@...utronix.de, mingo@...hat.com, tony.luck@...el.com
Subject: Re: [PATCH] xen/mce: don't issue error message for failed
 /dev/mcelog registration

On Tue, Jun 13, 2017 at 03:14:53PM +0200, Juergen Gross wrote:
> I'd rather avoid the pr_err() in the -EBUSY case. What about:
> 
> if (err) {
> 	if (err == -EBUSY)
> 		pr_info("Unable to init device /dev/mcelog, already registered");
> 	else
> 		pr_err("Unable to init device /dev/mcelog (rc: %d)\n", err);
> }

Sure.

Thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.