linux-kernel - Re: [PATCH net-next] of_mdio: move of_mdio_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Jun 2017 09:49:01 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Jon Mason <jon.mason@...adcom.com>, Andrew Lunn <andrew@...n.ch>,
        Rob Herring <robh+dt@...nel.org>,
        Frank Rowand <frowand.list@...il.com>
Cc:     netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Liviu Dudau <liviu@...au.co.uk>,
        Michael Ellerman <mpe@...erman.id.au>
Subject: Re: [PATCH net-next] of_mdio: move of_mdio_parse_addr to header file

On 06/13/2017 07:56 AM, Jon Mason wrote:
> The of_mdio_parse_addr() helper function is useful to other code, but
> the module dependency chain causes issues.  To work around this, we can
> move of_mdio_parse_addr() to be an inline function in the header file.
> This gets rid of the dependencies and still allows for the reuse of
> code.
> 
> Reported-by: Liviu Dudau <liviu@...au.co.uk>
> Signed-off-by: Jon Mason <jon.mason@...adcom.com>
> Fixes: 342fa1964439 ("mdio: mux: make child bus walking more permissive and errors more verbose")

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

Thanks!
-- 
Florian