linux-kernel - Re: [PATCH 2/2] tty/serial: atmel: make the driver DT only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170613195608.3tfckys7w42sgmiy@piout.net>
Date:   Tue, 13 Jun 2017 21:56:08 +0200
From:   Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Richard Genoud <richard.genoud@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] tty/serial: atmel: make the driver DT only

On 13/06/2017 at 17:50:25 +0300, Andy Shevchenko wrote:
> On Tue, Jun 13, 2017 at 4:40 PM, Alexandre Belloni
> <alexandre.belloni@...e-electrons.com> wrote:
> > Now that AVR32 is gone, platform_data are not used to initialize the driver
> > anymore, remove that path from the driver. Also remove the now unused
> > struct atmel_uart_data.
> 
> Nitpicks, not insisting on them at all, just a side comment.
> 
> > +       struct serial_rs485 *rs485conf = &port->rs485;
> > +       u32 rs485_delay[2];
> 
> + empty line?
> 

Okay

> > +       /* rs485 properties */
> 
> > +       if (of_property_read_u32_array(np, "rs485-rts-delay",
> > +                                      rs485_delay, 2) == 0) {
> 
> Now it can be one line I suppose (taking into account ...() == 0 ->
> !...() change)
> 

No, it still doesn't fit, I'll leave it as-is

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com