linux-kernel - Re: [PATCH] iio hid-sensor-trigger: add Kconfig depends on IIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170613211322.5ed84610@kernel.org>
Date:   Tue, 13 Jun 2017 21:13:22 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Alexander Wuerstlein <arw@....name>
Cc:     Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        linux-iio@...r.kernel.org (open list:IIO SUBSYSTEM AND DRIVERS),
        linux-kernel@...r.kernel.org (open list)
Subject: Re: [PATCH] iio hid-sensor-trigger: add Kconfig depends on
 IIO_BUFFER

On Mon, 12 Jun 2017 13:56:05 +0200
Alexander Wuerstlein <arw@....name> wrote:

> Building a kernel with my configuration failed with:
> > drivers/built-in.o: In function `hid_sensor_setup_batch_mode': staging/drivers/iio/common/hid-sensors/hid-sensor-trigger.c:104: undefined reference to `iio_buffer_set_attrs'  
> which is fixed by this patch.
> 
> Signed-off-by: Alexander Wuerstlein <arw@....name>
Added a fixes tag as the issue was only introduced very recently.

Applied to the togreg branch of iio.git.

Thanks,

Jonathan

> ---
>  drivers/iio/common/hid-sensors/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/common/hid-sensors/Kconfig b/drivers/iio/common/hid-sensors/Kconfig
> index 39188b72cd3b..80105378b0ba 100644
> --- a/drivers/iio/common/hid-sensors/Kconfig
> +++ b/drivers/iio/common/hid-sensors/Kconfig
> @@ -16,7 +16,7 @@ config HID_SENSOR_IIO_COMMON
>  
>  config HID_SENSOR_IIO_TRIGGER
>  	tristate "Common module (trigger) for all HID Sensor IIO drivers"
> -	depends on HID_SENSOR_HUB && HID_SENSOR_IIO_COMMON
> +	depends on HID_SENSOR_HUB && HID_SENSOR_IIO_COMMON && IIO_BUFFER
>  	select IIO_TRIGGER
>  	help
>  	  Say yes here to build trigger support for HID sensors.