linux-kernel - Re: [PATCH 10/12] tracing: Update sample file to describe the new macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170613170755.13331121@gandalf.local.home>
Date:   Tue, 13 Jun 2017 17:07:55 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Jeremy Linton <jeremy.linton@....com>
Cc:     linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
        mingo@...hat.com, rusty@...tcorp.com.au, jeyu@...hat.com,
        kirill.shutemov@...ux.intel.com, christoffer.dall@...aro.org,
        marc.zyngier@....com, jcm@...masters.org
Subject: Re: [PATCH 10/12] tracing: Update sample file to describe the new
 macro

On Wed, 31 May 2017 16:56:51 -0500
Jeremy Linton <jeremy.linton@....com> wrote:

> Add a blurb in the trace sample file to describe
> the macro used to add sizeof to value conversions.
> 
> Signed-off-by: Jeremy Linton <jeremy.linton@....com>
> ---
>  samples/trace_events/trace-events-sample.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/samples/trace_events/trace-events-sample.h b/samples/trace_events/trace-events-sample.h
> index 76a75ab..82e1e66 100644
> --- a/samples/trace_events/trace-events-sample.h
> +++ b/samples/trace_events/trace-events-sample.h
> @@ -225,6 +225,13 @@ TRACE_DEFINE_ENUM(TRACE_SAMPLE_FOO);
>  TRACE_DEFINE_ENUM(TRACE_SAMPLE_BAR);
>  TRACE_DEFINE_ENUM(TRACE_SAMPLE_ZOO);
>  
> +/*
> + * The same problem as above applies to sizeof(), so there is also
> + * a macro to solve that problem.
> + */
> +
> +TRACE_DEFINE_SIZEOF(pteval_t);
> +

Could you add this in the example too. That is, a use case. Just
having the define isn't a proper sample. You want to use it in a
TP_printk() too.

-- Steve

>  TRACE_EVENT(foo_bar,
>  
>  	TP_PROTO(const char *foo, int bar, const int *lst,