linux-kernel - Re: [PATCH][mmc-next] mmc: sdhci-pci: make guid intel_dsm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f9b36c7a-1c69-d825-2bc2-ccb986ab2b22@intel.com>
Date:   Wed, 14 Jun 2017 09:08:03 +0300
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Colin King <colin.king@...onical.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        linux-mmc@...r.kernel.org, Christoph Hellwig <hch@....de>
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][mmc-next] mmc: sdhci-pci: make guid intel_dsm_guid static

On 13/06/17 16:14, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The guid intel_dsm_guid does not need to be in global scope, so make
> it static.
> 
> Cleans up sparse warning:
> "symbol 'intel_dsm_guid' was not declared. Should it be static?"
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Acked-by: Adrian Hunter <adrian.hunter@...el.com>

But this patch is dependent on the guid changes which are not in the mmc
tree.  It's in a tree of Christoph's I think.

> ---
>  drivers/mmc/host/sdhci-pci-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
> index 3c02c5b394d6..f1d8385d91f0 100644
> --- a/drivers/mmc/host/sdhci-pci-core.c
> +++ b/drivers/mmc/host/sdhci-pci-core.c
> @@ -404,7 +404,7 @@ struct intel_host {
>  	bool	d3_retune;
>  };
>  
> -const guid_t intel_dsm_guid =
> +static const guid_t intel_dsm_guid =
>  	GUID_INIT(0xF6C13EA5, 0x65CD, 0x461F,
>  		  0xAB, 0x7A, 0x29, 0xF7, 0xE8, 0xD5, 0xBD, 0x61);
>  
>