linux-kernel - Re: [PATCHv2 0/5] OMAP4: crypto support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170614075750.GG3730@atomide.com>
Date:   Wed, 14 Jun 2017 00:57:51 -0700
From:   Tony Lindgren <tony@...mide.com>
To:     Tero Kristo <t-kristo@...com>
Cc:     Sebastian Reichel <sebastian.reichel@...labora.co.uk>,
        Paul Walmsley <paul@...an.com>,
        Benoît Cousson <bcousson@...libre.com>,
        Russell King <linux@...linux.org.uk>,
        linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2 0/5] OMAP4: crypto support

* Tero Kristo <t-kristo@...com> [170613 07:46]:
> On 13/06/17 17:24, Sebastian Reichel wrote:
> > Hi,
> > 
> > On Tue, Jun 13, 2017 at 04:49:18PM +0300, Tero Kristo wrote:
> > > On 13/06/17 12:28, Sebastian Reichel wrote:
> > > > This adds crypto support for OMAP4, which was missing for some reason.
> > > > This fixes error about missing hwmod on Droid 4. IP-Cores for AES and
> > > > DES are working according to selftest.
> > > > 
> > > > Changes since PATCHv1:
> > > >    * remove patch adding des_fck to DT
> > > >    * add patch removing aes[12]_fck from DT
> > > >    * add patch renaming hwmod aes to aes1 in DT
> > > >    * update hwmod patches according to feedback from Tero
> > > >    * add patch for aes2 hwmod
> > > > 
> > > > -- Sebastian
> > > 
> > > I just posted a few extra patches on top of this series, for adding
> > > the missing dts data for aes2 and adding sham accelerator also.
> > 
> > Thanks :)
> > 
> > > The dts data should be applied first if you want to avoid any
> > > issues with hwmod core complaining about missing DT data, so the
> > > sequencing of this series and mine need to be done carefully.
> > 
> > There is also a warning printed if DT references a missing hwmod
> > entry (that's how I noticed this in the first place). It's less
> > noisy, though. Since kernel builds and boots with any order and
> > crypto hardware does not work at the moment there is no real
> > problem with bisect. I suggest to merge the DTS patches normally
> > through the separate dt branch.
> 
> Yeah thats actually true also. Up to Tony to decide how he wants to handle
> these. The huge warning is mainly an annoyance.

Applying patches from both Sebastian's and Tero's sets into
split into omap-for-v4.13/dt and omap-for-v4.13/soc-v4 branches.

Thanks,

Tony