linux-kernel - Re: [PATCH] thunderbolt: Fix reset response

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMxnaaVEXLhkJ62s9pavySfsrim0puh-aRF3f7dEONeijTcoaQ@mail.gmail.com>
Date:   Wed, 14 Jun 2017 11:10:05 +0200
From:   Andreas Noever <andreas.noever@...il.com>
To:     Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Greg KH <gregkh@...uxfoundation.org>
Cc:     Michael Jamet <michael.jamet@...el.com>,
        Yehezkel Bernat <yehezkel.bernat@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] thunderbolt: Fix reset response_type

On Wed, Jun 14, 2017 at 10:42 AM, Mika Westerberg
<mika.westerberg@...ux.intel.com> wrote:
> On Wed, Jun 14, 2017 at 10:47:21AM +0300, Dan Carpenter wrote:
>> There is a mistake here where we accidentally use sizeof(TB_CFG_PKG_RESET)
>> instead of just TB_CFG_PKG_RESET.  The size of an int is 4 so it's the
>> same as TB_CFG_PKG_NOTIFY_ACK.
>>
>> Fixes: d7f781bfdbf4 ("thunderbolt: Rework control channel to be more reliable")
>> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
>
> Good catch!
>
> Acked-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
Signed-off-by: Andreas Noever <andreas.noever@...il.com>