linux-kernel - Re: [PATCH] fbdev: avoid int-in-bool-context warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 14 Jun 2017 12:04:38 +0200
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fbdev: avoid int-in-bool-context warning

On Thursday, May 11, 2017 02:47:01 PM Arnd Bergmann wrote:
> gcc-7 suspects this code might be wrong because we use the
> result of a multiplication as a bool:
> 
> drivers/video/fbdev/core/fbmon.c: In function 'fb_edid_add_monspecs':
> drivers/video/fbdev/core/fbmon.c:1051:84: error: '*' in boolean context, suggest '&&' instead [-Werror=int-in-bool-context]
> 
> It's actually fine, so let's add a comparison to zero to make
> that clear to the compiler too.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Patch queued for 4.12, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics